Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino-mk: init at 1.6.0 #52112

Merged
merged 2 commits into from Feb 3, 2019
Merged

arduino-mk: init at 1.6.0 #52112

merged 2 commits into from Feb 3, 2019

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Dec 14, 2018

Motivation for this change

Standard package in ubuntu etc. so this makes it easy to include it in the default configuration.nix, without having to do additional configuration in $HOME.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

grahamc
grahamc reviewed Dec 14, 2018
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@grahamc
Copy link
Member

grahamc commented Dec 14, 2018 •
edited

@GrahamcOfBorg build arduino-mk

@lheckemann
Copy link
Member

If this is used entirely without modification, I think it might make sense to symlink rather than copying $src to $out, thus avoiding duplication of all the files. In fact, if fetchFromGitHub allowed custom metadata it could just be used without another derivation wrapping it at all…

@eyJhb
Copy link
Member Author

eyJhb commented Dec 16, 2018

@lheckemann so you propose just doing a ln -s $src $out ?

@lheckemann
Copy link
Member

Yes.

@grahamc
Copy link
Member

grahamc commented Jan 30, 2019 •
edited

@GrahamcOfBorg build arduino-mk

@eyJhb
Copy link
Member Author

eyJhb commented Feb 2, 2019

@grahamc can you build again and merge if everything passes?

@lheckemann
Copy link
Member

@GrahamcOfBorg build arduino-mk

@eyJhb
Copy link
Member Author

eyJhb commented Feb 3, 2019

So all checks have passed, ready to merge I guess?
@lheckemann @grahamc

@matthewbauer matthewbauer merged commit 43bd6a3 into NixOS:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@grahamc grahamc grahamc left review comments

@lheckemann lheckemann lheckemann left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eyJhb @grahamc @lheckemann @matthewbauer @GrahamcOfBorg