Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-changelog-generator: init at v1.14.3 #52176

Merged
merged 1 commit into from Dec 17, 2018
Merged

github-changelog-generator: init at v1.14.3 #52176

merged 1 commit into from Dec 17, 2018

Conversation

Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Dec 15, 2018 •
edited

Motivation for this change

This tool is part of our development pipeline

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi force-pushed the github-changelog-generator branch 2 times, most recently from 36883e0 to 323042c Compare December 17, 2018 09:43
alyssais
alyssais requested changes Dec 17, 2018
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there! Thanks for the changes.

pkgs/development/tools/github-changelog-generator/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/github-changelog-generator/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/github-changelog-generator/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/github-changelog-generator/default.nix Outdated Show resolved Hide resolved
alyssais
alyssais requested changes Dec 17, 2018
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of style tweaks :)

pkgs/development/tools/github-changelog-generator/default.nix Show resolved Hide resolved
pkgs/development/tools/github-changelog-generator/default.nix Outdated Show resolved Hide resolved
@Scriptkiddi
github-changelog-generator: init at v1.14.3
82d9c2b 
Signed-off-by: Fritz Otlinghaus <fritz@otlinghaus.it>
fpletz
fpletz approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 👍 :)

@fpletz fpletz merged commit 758f271 into NixOS:master Dec 17, 2018
@Scriptkiddi Scriptkiddi deleted the github-changelog-generator branch December 18, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Scriptkiddi @fpletz @alyssais @GrahamcOfBorg