New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gif-for-cli: init and pythonPackages.x256: init at 0.0.3 #52178
Conversation
(cherry picked from commit b499f92)
(cherry picked from commit 6fcc67e)
…018-11-21 Backport NixOS#50879
(cherry picked from commit 5879586)
(cherry picked from commit 86f9ac2)
(cherry picked from commit 13e38d8)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/batctl/versions (cherry picked from commit 6d8f22a)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/alfred/versions (cherry picked from commit 40ea9c7)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/batctl/versions (cherry picked from commit 119e4e3)
(cherry picked from commit b62a18b)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/riot-web/versions (cherry picked from commit 5d88d54)
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/riot-web/versions (cherry picked from commit f091b32)
(cherry picked from commit 64da5fc)
(cherry picked from commit 8ff9e78)
(cherry picked from commit f885437)
(cherry picked from commit 376f4b9)
(cherry picked from commit e5deb04)
https://sqlite.org/releaselog/3_25_0.html (cherry picked from commit 0c7b157)
(cherry picked from commit daf738f)
(cherry picked from commit 2e27401)
https://sqlite.org/releaselog/3_25_3.html (cherry picked from commit 6f0c65e)
(cherry picked from commit b8229dd)
With this commit, we *can* swap python2 for python3 to run synapse using python3 instead. The reason for not making the switch is that a number of CLI tools provided with synapse do not yet work under py3 despite synapse running fine. So this doesn't actually do anything on its own except to prepare for the upcoming py3 switch. (cherry picked from commit dc74c44)
(cherry picked from commit 2bf16cb)
(cherry picked from commit 5ea22c4)
(cherry picked from commit 956a4b2) Fixes NixOS#50938
Multiple CVE fixes.
This fixes the problem of connecting android phones via MTP in kde/dolphin. Original Bug description: https://bugs.kde.org/show_bug.cgi?id=387454 (cherry picked from commit 79f148c)
libmtp: 1.1.15 -> 1.1.16
(cherry picked from commit 5a15ab7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs should be made against master: https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches
}; | ||
|
||
meta = with stdenv.lib; { | ||
description = "Return the nearest xterm 256 color code for rgb inputs."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
meta = with stdenv.lib; { | ||
homepage = https://github.com/google/gif-for-cli; | ||
description = "Takes in a GIF, short video, or a query to the Tenor GIF API and converts it to animated ASCII art."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, fetchFromGitHub, python3Packages, ffmpeg, zlib, libjpeg }: | ||
|
||
python3Packages.buildPythonApplication rec { | ||
name = "gif-for-cli"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pname
, version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will add pname,
gif-for-cli has no version number which should I take then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then use unstable-YYYY-MM-DD
with the date of the commit you use.
python3Packages.buildPythonApplication rec { | ||
name = "gif-for-cli"; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the meta
block at the bottom.
sha256 = "1rj8wjfsabn27k1ds7a5fdqgf2r28zpz4lvhbzssjfj1yf0mfh7s"; | ||
}; | ||
|
||
propagatedBuildInputs = [ ffmpeg zlib libjpeg python3Packages.pillow python3Packages.requests python3Packages.x256 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only python packages belong here
|
||
checkInputs = [ python3Packages.coverage ]; | ||
|
||
src = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not fetchPypi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not have a pypi package
@@ -0,0 +1,20 @@ | |||
{ stdenv, buildPythonPackage, fetchPypi | |||
}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why that space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create 2 separate commits.
switeched over here #52201 |
Motivation for this change
Wanted to use it for my dotfiles
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)