Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gif-for-cli: init and pythonPackages.x256: init at 0.0.3 #52178

Closed
wants to merge 1,599 commits into from

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

Wanted to use it for my dotfiles

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [ x Fits CONTRIBUTING.md.

Ingolf Wagner and others added 30 commits November 23, 2018 03:39
(cherry picked from commit 5879586)
(cherry picked from commit 86f9ac2)
(cherry picked from commit 13e38d8)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/batctl/versions

(cherry picked from commit 6d8f22a)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/alfred/versions

(cherry picked from commit 40ea9c7)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/batctl/versions

(cherry picked from commit 119e4e3)
(cherry picked from commit b62a18b)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/riot-web/versions

(cherry picked from commit 5d88d54)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/riot-web/versions

(cherry picked from commit f091b32)
(cherry picked from commit 64da5fc)
(cherry picked from commit 8ff9e78)
(cherry picked from commit f885437)
(cherry picked from commit 376f4b9)
(cherry picked from commit e5deb04)
(cherry picked from commit daf738f)
(cherry picked from commit 2e27401)
With this commit, we *can* swap python2 for python3 to run synapse using python3
instead.

The reason for not making the switch is that a number of CLI tools provided with
synapse do not yet work under py3 despite synapse running fine.

So this doesn't actually do anything on its own except to prepare for the
upcoming py3 switch.

(cherry picked from commit dc74c44)
(cherry picked from commit 2bf16cb)
(cherry picked from commit 5ea22c4)
This fixes the problem of connecting android phones via MTP in kde/dolphin.

Original Bug description: https://bugs.kde.org/show_bug.cgi?id=387454

(cherry picked from commit 79f148c)
(cherry picked from commit 5a15ab7)
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

};

meta = with stdenv.lib; {
description = "Return the nearest xterm 256 color code for rgb inputs.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


meta = with stdenv.lib; {
homepage = https://github.com/google/gif-for-cli;
description = "Takes in a GIF, short video, or a query to the Tenor GIF API and converts it to animated ASCII art.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ stdenv, fetchFromGitHub, python3Packages, ffmpeg, zlib, libjpeg }:

python3Packages.buildPythonApplication rec {
name = "gif-for-cli";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname, version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will add pname,
gif-for-cli has no version number which should I take then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then use unstable-YYYY-MM-DD with the date of the commit you use.

python3Packages.buildPythonApplication rec {
name = "gif-for-cli";

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the meta block at the bottom.

sha256 = "1rj8wjfsabn27k1ds7a5fdqgf2r28zpz4lvhbzssjfj1yf0mfh7s";
};

propagatedBuildInputs = [ ffmpeg zlib libjpeg python3Packages.pillow python3Packages.requests python3Packages.x256 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only python packages belong here


checkInputs = [ python3Packages.coverage ];

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fetchPypi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not have a pypi package

@@ -0,0 +1,20 @@
{ stdenv, buildPythonPackage, fetchPypi
}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that space?

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create 2 separate commits.

@Scriptkiddi
Copy link
Contributor Author

switeched over here #52201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment