Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: add jakelogemann user. #52095

Merged
merged 3 commits into from Dec 14, 2018
Merged

maintainers: add jakelogemann user. #52095

merged 3 commits into from Dec 14, 2018

Conversation

jakelogemann
Copy link
Member

@jakelogemann jakelogemann commented Dec 14, 2018 •
edited

Motivation for this change

I'd like to assist maintaining packages/modules, since I'm tired of maintaining a local clone/fork!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jakelogemann jakelogemann changed the title maintainers: add jlogemann user. maintainers: add jakelogemann user. Dec 14, 2018
@jakelogemann
Copy link
Member Author

jakelogemann commented Dec 14, 2018 •
edited

Is this something I can/should fix?

@veprbl veprbl merged commit 2f9934d into NixOS:master Dec 14, 2018
@veprbl
Copy link
Member

veprbl commented Dec 14, 2018

@jakelogemann Congratulations on the first commit!

@jakelogemann jakelogemann deleted the patch-1 branch December 14, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakelogemann @veprbl @GrahamcOfBorg @Janik-Haag