Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add premake & imake setup hook #51205

Merged
merged 26 commits into from Nov 30, 2018
Merged

Conversation

matthewbauer
Copy link
Member

Motivation for this change

Add setup hooks for imake & premake. Both override the default configure phase. To make everything work, I've rewritten a few packages to work with the configure phase. Some packages use imake with a configure script, so those have to be passed dontUseImakeConfigure.

Adds a configure phase for packages using premake.
premakeConfigurePhase runs the correct premake version for the premake
you are using (see premake_cmd).
A few changes needed here:

- We don’t want to guess what our platform is. We can patch location
  and targetdir to not put things in an unpredictable directory.
- Make premake4 a native build input.
- Set the premakefile variable.
Simplifies some things here.
Cleans things up a bit here.
We need to set dontUseImakeConfigure in a few places to prevent imake
from overriding the default configure phase. This packages all have a
configure script that needs to get run:

- Xaw3d
- R
- tkgate
- ssvnc
@matthewbauer
Copy link
Member Author

@GrahamcOfBorg build bootil yojimbo distrho gmad otfcc tome4 oneko xcruiser xmove xxkb xearth larswm xsnow xautolock x2x xbrightness xvkbd xzoom transfig x11-ssh-askpass vncrec nas tightvnc ssvnc tkgate R

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bootil, yojimbo, distrho, otfcc, tome4, oneko, xcruiser, xxkb, xearth, larswm, xautolock, x2x, xbrightness, xvkbd, xzoom, transfig, vncrec, nas, tightvnc, ssvnc, tkgate, R

The following builds were skipped because they don't evaluate on x86_64-linux: gmad, xmove, xsnow, x11-ssh-askpass

Partial log (click to expand)

/nix/store/knnmaskl7hz2azh6xzl34vmg4cvm83z7-xbrightness-0.3-mika-akk
/nix/store/2d1xb858djkadwpzvxr7g4y2qda7vvdw-xvkbd-3.9
/nix/store/6x6ykgarvrgdff176fg3d6cvhqakkn5m-xzoom-0.3.24
/nix/store/bn3lrkkqfwfp618harvhrg9p28b0knkq-transfig-3.2.4
/nix/store/6mvn2lkzj71v1b7cjs6h8fmd1csf9277-vncrec-0.2
/nix/store/q816bh7136jj49h4148sydfb1d20vagg-nas-1.9.4
/nix/store/v6s4r81c14yxvflnpm3sy0p4ahadkcg6-tightvnc-1.3.10
/nix/store/xvgl23q3n79y5aj3cnslnyqpq92g2zrz-ssvnc-1.0.29
/nix/store/yrabfwyzy6y1j3cfgrww485a3cj0yxzj-tkgate-1.8.7
/nix/store/ihfviz857jn3l52r544pn9zycfpmmc50-R-3.5.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: bootil, oneko, xcruiser, xxkb, xearth, larswm, xautolock, x2x, xbrightness, xvkbd, xzoom, transfig, vncrec, nas, tightvnc, tkgate, R

The following builds were skipped because they don't evaluate on aarch64-linux: yojimbo, distrho, gmad, otfcc, tome4, xmove, xsnow, x11-ssh-askpass, ssvnc

Partial log (click to expand)

shrinking /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/lib/R/modules/internet.so
shrinking /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/lib/R/lib/libR.so
shrinking /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/lib/R/bin/exec/R
shrinking /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/lib/R/bin/Rscript
gzipping man pages under /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/lib  /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1/bin
patching script interpreter paths in /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1
checking for references to /build in /nix/store/kcigda63h21q5iw39r706b6izsmww3cq-R-3.5.1...
error: build of '/nix/store/1jfvi3ahcqcywdqxzgx9fn4cy66lg4p5-tightvnc-1.3.10.drv', '/nix/store/5zl6f7hvbg1zrj1zivm9nhld4k7ly1jf-bootil-unstable-2015-12-17.drv', '/nix/store/6jamqs56wn6fzw2xwjc5n72x9g1kw7bk-tkgate-1.8.7.drv', '/nix/store/70zs60ar3lzp4jj0l6j2j05wrkx1kxq5-vncrec-0.2.drv', '/nix/store/brpr83gfi21gm34xi4ip5iw7qrdqh9v8-xbrightness-0.3-mika-akk.drv', '/nix/store/c1hv5jgj1yv1z3gy7a8s1lzvgv08z8kn-xautolock-2.2.drv', '/nix/store/gwpaxjvbq1j5dkjwq7dmz59adhzvqwgx-oneko-1.2.5.drv', '/nix/store/j743k6j1ygl9xw7vlzcs6a76swrlz7mq-x2x-1.27.drv', '/nix/store/mq2687i3p199ychqsj6241xrg4c4i4wl-larswm-7.5.3.drv', '/nix/store/n9wa9jc964y6kgcmz4453zs82yg5wcyj-xzoom-0.3.24.drv', '/nix/store/nmaca3va1xpj5sx1901ja5n8bjsfnrxy-transfig-3.2.4.drv', '/nix/store/pbrczkwgdisbaai7rlpizyi32k0ivzs3-xearth-1.1.drv', '/nix/store/ph0afircl13ph6fpip5ym3xn64i5vv78-xxkb-1.11.1.drv', '/nix/store/y0l335k7g733w1c9q4jmc3z6qvy9pqc3-xcruiser-0.30.drv', '/nix/store/yd22b0rlidnf4w8fby831ln76ly18lhp-xvkbd-3.9.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bootil, yojimbo, otfcc, oneko, xearth, transfig, tightvnc, tkgate, R

The following builds were skipped because they don't evaluate on x86_64-darwin: distrho, gmad, tome4, xcruiser, xmove, xxkb, larswm, xsnow, xautolock, x2x, xbrightness, xvkbd, xzoom, x11-ssh-askpass, vncrec, nas, ssvnc

Partial log (click to expand)

/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib
/nix/store/7q2200nrwiyby3cnhvib0nmd984m0bwm-R-3.5.1/lib/R/lib/libR.dylib: fixing dylib

@matthewbauer matthewbauer merged commit 76c7a8b into NixOS:master Nov 30, 2018
@matthewbauer matthewbauer deleted the more-setup-hooks branch February 22, 2019 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants