Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f2fs-tools: fix cross compilation #51204

Merged
merged 1 commit into from Nov 29, 2018
Merged

f2fs-tools: fix cross compilation #51204

merged 1 commit into from Nov 29, 2018

Conversation

eburimu
Copy link
Contributor

@eburimu eburimu commented Nov 29, 2018

Motivation for this change

Fixes:

 8469 configuring
 8470 fixing libtool script ./build-aux/ltmain.sh
 8471 configure flags: --disable-static --disable-dependency-tracking --prefix=/nix/store/hqz4nqa2gpmhh57zwqyidgvxdxcncz5l-f2fs-tools-1.11.0-armv7l-unknown-linux-gnueabihf --build=x86_64-unknown-linux-gnu --host=armv7l-unknown-linux-gnuea\
      bihf
 8472 checking for .git... configure: error: cannot check for file existence when cross compiling
 8473 builder for '/nix/store/sp97qpr6qy1mvr05149nd9lb66zsqdy2-f2fs-tools-1.11.0-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 1
 8474 error: build of '/nix/store/sp97qpr6qy1mvr05149nd9lb66zsqdy2-f2fs-tools-1.11.0-armv7l-unknown-linux-gnueabihf.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have disabled an autoconf macro that inserts tool date from git. This doesn't implicate any source code change.

@Ericson2314
Copy link
Member

Nice fix.

@c0bw3b c0bw3b added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 29, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 29, 2018

@GrahamcOfBorg build f2fs-tools pkgsCross.aarch64-multiplatform.f2fs-tools

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: pkgsCross.aarch64-multiplatform.f2fs-tools

The following builds were skipped because they don't evaluate on x86_64-darwin: f2fs-tools

Partial log (click to expand)

cannot build derivation '/nix/store/qd8lapz3akk28mfy5yb3v1rfdb47gm96-readline-6.3p08-aarch64-unknown-linux-gnu.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/bimw7hbsw53pl68ckp6jigmdxshh51d8-sqlite-3.25.3-aarch64-unknown-linux-gnu.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/vp0qyyx6qw6xd5mi8c17a7d7bjqb2zil-swig-3.0.12-aarch64-unknown-linux-gnu.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/vv1aifnnxs76f6drc6jwwwj7g124s36c-linux-pam-1.3.0-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/15kwrn1jps6pabhwsgncx51z7lpdxwll-python-2.7.15-aarch64-unknown-linux-gnu.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/9rn03cdb3w9wziw3ixvqyw55bigx6v3j-libselinux-2.7-aarch64-unknown-linux-gnu.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jb0dfrdzwzi5bhvsaylz2szwpv2mck4l-shadow-4.6-aarch64-unknown-linux-gnu.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/d98whwyanzdnfwgzm18s5xn2wsl9vim2-util-linux-2.33-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/yybsk9y9mql97xqvwpqjhjj9i232fn2m-f2fs-tools-1.11.0-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
error: build of '/nix/store/yybsk9y9mql97xqvwpqjhjj9i232fn2m-f2fs-tools-1.11.0-aarch64-unknown-linux-gnu.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: f2fs-tools, pkgsCross.aarch64-multiplatform.f2fs-tools

Partial log (click to expand)

cannot build derivation '/nix/store/h5yvnc79ya3x8dp34sq7csyid7ryial7-readline-6.3p08-aarch64-unknown-linux-gnu.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/55zlxaf8vwq1gcixvi5lrj2vmbl6s0k6-sqlite-3.25.3-aarch64-unknown-linux-gnu.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8ndrw4nmsi3lx12wrwnhinnycapmb0zy-swig-3.0.12-aarch64-unknown-linux-gnu.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/nhx4y3vny2l9ib7sl374bx8sxc9cjffh-linux-pam-1.3.0-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/vqbccxsbsqnc17cn4qi87wbibbrslqar-python-2.7.15-aarch64-unknown-linux-gnu.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/rvblznizag6bqdqny1jra213iwl1vz21-libselinux-2.7-aarch64-unknown-linux-gnu.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/rqlxwdv5dyhlmr9r2p76q50hlqx603ps-shadow-4.6-aarch64-unknown-linux-gnu.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/hbwwvqiqraiarfb9bb37myxx476zhwy9-util-linux-2.33-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/3j20ksymj1mrbvvvjpbwbdlhw6a89gzx-f2fs-tools-1.11.0-aarch64-unknown-linux-gnu.drv': 6 dependencies couldn't be built
error: build of '/nix/store/3j20ksymj1mrbvvvjpbwbdlhw6a89gzx-f2fs-tools-1.11.0-aarch64-unknown-linux-gnu.drv', '/nix/store/rnl6jschqf2wr1ab5mx7rjq1s4zl220w-f2fs-tools-1.11.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: f2fs-tools, pkgsCross.aarch64-multiplatform.f2fs-tools

Partial log (click to expand)

shrinking /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/lib/libf2fs_format.so.4.0.0
shrinking /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/lib/libf2fs.so.5.0.0
gzipping man pages under /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/share/man/
strip is /nix/store/kjh00kmvpdvy82y17rxgj41c908my324-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/lib  /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/sbin
patching script interpreter paths in /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0
checking for references to /build/ in /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0...
moving /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/sbin/* to /nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0/bin
/nix/store/nl6s68ghv4mqlmz2aygccag7i9596il0-f2fs-tools-1.11.0
/nix/store/40lf1cpjw54f3w54prqnagnxcpn2brl1-f2fs-tools-1.11.0

@Ericson2314 Ericson2314 changed the base branch from staging to master November 29, 2018 20:25
@Ericson2314 Ericson2314 changed the base branch from master to staging November 29, 2018 20:26
@Ericson2314
Copy link
Member

Eh screw it, staging is fine.

@Ericson2314 Ericson2314 merged commit 071eba2 into NixOS:staging Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: erlang 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eburimu @Ericson2314 @Mic92 @GrahamcOfBorg @c0bw3b