Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclone: 1.44 -> 1.45 #51186

Merged
merged 1 commit into from Nov 29, 2018
Merged

rclone: 1.44 -> 1.45 #51186

merged 1 commit into from Nov 29, 2018

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Updated to latest version. See https://rclone.org/changelog/

Also added subPackages = [ "." ] since otherwise we end up with a binary called test_all in the output.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Nov 29, 2018

Built and tested locally 👍
As the expression specifies platforms.all, let's run ofborg just to be sure :)

@GrahamcOfBorg build rclone

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rclone

Partial log (click to expand)

strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bjfz85q5vbnk69di5b1yd17w0i89ma2l-rclone-1.45-bin/bin
patching script interpreter paths in /nix/store/bjfz85q5vbnk69di5b1yd17w0i89ma2l-rclone-1.45-bin
checking for references to /build in /nix/store/bjfz85q5vbnk69di5b1yd17w0i89ma2l-rclone-1.45-bin...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
shrinking RPATHs of ELF executables and libraries in /nix/store/pcz2wlhx9adxgzjrl8mbni7cb7m8ggqs-rclone-1.45-man
gzipping man pages under /nix/store/pcz2wlhx9adxgzjrl8mbni7cb7m8ggqs-rclone-1.45-man/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pcz2wlhx9adxgzjrl8mbni7cb7m8ggqs-rclone-1.45-man
checking for references to /build in /nix/store/pcz2wlhx9adxgzjrl8mbni7cb7m8ggqs-rclone-1.45-man...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rclone

Partial log (click to expand)

find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
find: '/nix/store/3hanh4l5225gn81p2jvqjfcgkskdak6i-rclone-1.45': No such file or directory
gzipping man pages under /nix/store/7zplfn82j229p46sf2qb8x9pmpvdd0kl-rclone-1.45-man/share/man/
strip is /nix/store/mvpvjar6m4jpjcz48715w2pax53djv6g-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/7zplfn82j229p46sf2qb8x9pmpvdd0kl-rclone-1.45-man
/nix/store/00fv0nqh73m6lzy4k3qjs3qwp9zsj3pf-rclone-1.45-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rclone

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/62x3l5a68rppnlj0lf1l0cjjv080nwdy-rclone-1.45-bin/bin
patching script interpreter paths in /nix/store/62x3l5a68rppnlj0lf1l0cjjv080nwdy-rclone-1.45-bin
checking for references to /build in /nix/store/62x3l5a68rppnlj0lf1l0cjjv080nwdy-rclone-1.45-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
shrinking RPATHs of ELF executables and libraries in /nix/store/dyalv8nqbg68gxkr0szxl7ifbhlrj3qj-rclone-1.45-man
gzipping man pages under /nix/store/dyalv8nqbg68gxkr0szxl7ifbhlrj3qj-rclone-1.45-man/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/dyalv8nqbg68gxkr0szxl7ifbhlrj3qj-rclone-1.45-man
checking for references to /build in /nix/store/dyalv8nqbg68gxkr0szxl7ifbhlrj3qj-rclone-1.45-man...
/nix/store/62x3l5a68rppnlj0lf1l0cjjv080nwdy-rclone-1.45-bin

@Ma27 Ma27 merged commit f38d805 into NixOS:master Nov 29, 2018
@Ma27
Copy link
Member

Ma27 commented Nov 29, 2018

@danielfullmer thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielfullmer @Ma27 @GrahamcOfBorg