Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iso-image: Verifies the FAT partition at build. #51199

Merged
merged 2 commits into from
Dec 1, 2018
Merged

iso-image: Verifies the FAT partition at build. #51199

merged 2 commits into from
Dec 1, 2018
+3 −1

Conversation

samueldr
Copy link
Member

This is done to ensure mtools-based operations leave a clean FS.

Motivation for this change

See #51158 (comment)

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

cc @dezgeg

@samueldr samueldr requested a review from infinisil as a code owner November 29, 2018 00:13
@samueldr samueldr changed the title iso-image: Verifies the FAT partition at build. WIP iso-image: Verifies the FAT partition at build. Nov 29, 2018
@samueldr
iso-image: Verifies the FAT partition at build.
0a367c4 
This is done to ensure `mtools`-based operations leave a clean FS.
@samueldr
iso-image: Do not use batch operations for mcopy.
3864438 
```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See NixOS#51150
@samueldr samueldr force-pushed the fix/iso-image-fat32 branch from a93b939 to 3864438 Compare November 29, 2018 00:15
@samueldr
Copy link
Member Author

Force push is to split in two commits.

@samueldr samueldr changed the title WIP iso-image: Verifies the FAT partition at build. iso-image: Verifies the FAT partition at build. Nov 29, 2018
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 29, 2018
@c0bw3b c0bw3b merged commit 947be9e into NixOS:master Dec 1, 2018
@samueldr samueldr deleted the fix/iso-image-fat32 branch February 12, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samueldr @c0bw3b @GrahamcOfBorg