Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iso-image: Verifies the FAT partition at build. #51199

Merged
merged 2 commits into from Dec 1, 2018

Conversation

samueldr
Copy link
Member

This is done to ensure mtools-based operations leave a clean FS.

Motivation for this change

See #51158 (comment)

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

cc @dezgeg

@samueldr samueldr changed the title iso-image: Verifies the FAT partition at build. WIP iso-image: Verifies the FAT partition at build. Nov 29, 2018
This is done to ensure `mtools`-based operations leave a clean FS.
```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See NixOS#51150
@samueldr
Copy link
Member Author

Force push is to split in two commits.

@samueldr samueldr changed the title WIP iso-image: Verifies the FAT partition at build. iso-image: Verifies the FAT partition at build. Nov 29, 2018
@c0bw3b c0bw3b merged commit 947be9e into NixOS:master Dec 1, 2018
@samueldr samueldr deleted the fix/iso-image-fat32 branch February 12, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants