Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 0.56.12 -> 0.56.15 (70.0.3538.77 -> 70.0.3538.110) #51194

Merged
merged 1 commit into from Nov 29, 2018
Merged

brave: 0.56.12 -> 0.56.15 (70.0.3538.77 -> 70.0.3538.110) #51194

merged 1 commit into from Nov 29, 2018

Conversation

rht
Copy link
Member

@rht rht commented Nov 28, 2018

Motivation for this change

TODO: incorporate #49797 later on for v0.57.x (v71 base build).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

@GrahamcOfBorg build brave

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: brave

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: brave

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: brave

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15/bin/brave
gzipping man pages under /nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15/bin
patching script interpreter paths in /nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15
/nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15/opt/brave.com/brave/cron/brave-browser: interpreter directive changed from "/bin/sh" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15...
/nix/store/z5vxbkxb9dqkhhq1srm61qk4kp14r4s0-brave-0.56.15

@Ekleog
Copy link
Member

Ekleog commented Nov 29, 2018

@rht Could you open a backport PR against release-18.09, using git cherry-pick -x? :)

worldofpeace
worldofpeace approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to build and execute this locally.
The desktop item also appears correctly when installed with nix-env.

@worldofpeace
Copy link
Contributor

@rht Could you open a backport PR against release-18.09, using git cherry-pick -x? :)

But brave isn't in the release 😉

@Ekleog
Copy link
Member

Ekleog commented Nov 29, 2018

Oh. I assumed it was, sorry for the noise 😅

@worldofpeace worldofpeace merged commit 892407a into NixOS:master Nov 29, 2018
@worldofpeace
Copy link
Contributor

@rht Thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rht @kalbasit @GrahamcOfBorg @Ekleog @worldofpeace