Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b7747ce27ef6
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 09c74d944d8d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 29, 2018

  1. sd-image: Verifies the FAT partition before copying it. 

    This is to ensure `mtools`-based operations don't wreck the FS.

(cherry picked from commit 2e5eb13)
    @samueldr
    samueldr committed Nov 29, 2018
    Copy the full SHA
    19f0f47 View commit details
    Browse the repository at this point in the history

  2. sd-image: Do not use batch operation for mcopy. 

    ```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See #51150

(cherry picked from commit 1b6a4d3)
    @samueldr
    samueldr committed Nov 29, 2018
    Copy the full SHA
    09c74d9 View commit details
    Browse the repository at this point in the history