Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6854: Compilation with ICU 62 #6912

Merged
merged 1 commit into from Sep 20, 2018
Merged

Fix #6854: Compilation with ICU 62 #6912

merged 1 commit into from Sep 20, 2018

Conversation

steils
Copy link
Contributor

@steils steils commented Sep 19, 2018

No description provided.

@frosch123 frosch123 merged commit fec44b0 into OpenTTD:master Sep 20, 2018
@steils steils deleted the icu branch September 20, 2018 23:55
@matthijskooijman
Copy link
Contributor

For future reference, this actually fixes the build with ICU 61 and up. See the ICU 61 changelog:

C++ call sites need to qualify ICU types explicitly, for example icu::UnicodeString, or do using icu::UnicodeString; where appropriate. If your code relies on the "using namespace icu;" that used to be in unicode/uversion.h, then you need to update your code. (#13460)

@matthijskooijman
Copy link
Contributor

Also note that this PR did not fix the problem completely, see #6690 and the fix in 19076c2.

@LordAro
Copy link
Member

LordAro commented Nov 16, 2018

Only #6693 was strictly necessary for 61(.1), as far as I'm aware

@matthijskooijman
Copy link
Contributor

I believe it was more a matter of compilation options: All the things fixed by 19076c2 are inside WITH_ICU_SORT, whereas the fixes in #6693 are guarded by WITH_ICU_LAYOUT.

Doesn't matter much, though :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants