Skip to content

elfutils: 0.174 -> 0.175, clean a bit, fix and enable tests and hardening #50456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

elfutils: 0.174 -> 0.175, clean a bit, fix and enable tests and hardening #50456

wants to merge 7 commits into from
+99 −9

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: elfutils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: elfutils

Partial log (click to expand)

============================================================================
See tests/test-suite.log
Please report to https://sourceware.org/bugzilla
============================================================================
make[3]: *** [Makefile:2268: test-suite.log] Error 1
make[2]: *** [Makefile:2376: check-TESTS] Error 2
make[1]: *** [Makefile:3871: check-am] Error 2
make: *** [Makefile:486: check-recursive] Error 1
builder for '/nix/store/q64360nsx3drf4nnfazkrfbqj9h4yvd9-elfutils-0.175.drv' failed with exit code 2
error: build of '/nix/store/q64360nsx3drf4nnfazkrfbqj9h4yvd9-elfutils-0.175.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elfutils

Partial log (click to expand)

# TOTAL: 204
# PASS:  200
# SKIP:  4
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[1]: Nothing to be done for 'installcheck-am'.
/nix/store/lg5z2kv2grd72dss0mbsw7w45wy9ds1b-elfutils-0.175

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 22, 2018

I'm seeing this PR after I merged #50797 so the version bump is done in staging already.

Regarding build checks: there is still one failing on aarch64 -> FAIL: run-backtrace-native.sh

The rest LGTM (removing bzip2, keeping format hardening, support for PaX flags)

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 2, 2018

The patch to support PaX flags should be fetched from:
https://bugs.gentoo.org/attachment.cgi?id=74902&action=diff&collapsed=&headers=1&format=raw

@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

I think "yes" but just checking--do we still want to include support for PaX flags here?

@dtzWill dtzWill force-pushed the update/elfutils-0.175 branch from 3c43ca3 to 245f768 Compare December 29, 2018 20:57
@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

I think that fixes the aarch64 test situation? :)

@dtzWill dtzWill force-pushed the update/elfutils-0.175 branch from 9f772eb to 07b3f9c Compare January 5, 2019 18:37
@GrahamcOfBorg GrahamcOfBorg requested a review from edolstra January 5, 2019 18:53
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@Ekleog
Copy link
Member

Ekleog commented Apr 7, 2019

@dtzWill Any reason for not merging?

@doronbehar
Copy link
Contributor

Please close this, elfutils' current version in master is 0.176.

@c0bw3b c0bw3b closed this Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @GrahamcOfBorg @c0bw3b @Ekleog @doronbehar @infinisil