nix/eval-machine-info.nix: fix evaluation with nixpkgs master #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The evaluation broken with NixOS/nixpkgs@6c68fbd I have no idea why this file was imported in the first place: NixOS@bac59ad#diff-6f15e27c3e048b98302b636c2b8f983bR7 I just removed it and it is still working for my `none` backend. However since this is file is sufficiently complex I cannot tell what the general consequence of removing is.
|
cc @edolstra if you still can tell why testing was imported relevant nixpkgs issue: NixOS/nixpkgs#50419 |
|
Was |
Closed
infinisil
added a commit
to infinisil/system
that referenced
this pull request
Nov 25, 2018
For NixOS/nixops#1047 Also install custom nixops version
|
@AmineChikhaoui can we get a new release? |
|
I had prepared a release here: #1050 |
|
nixopsUnstable also carries the fix and was backported to stable. |
|
When does this get released into the wild? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluation broken with NixOS/nixpkgs@6c68fbd
I have no idea why this file was imported in the first place:
bac59ad#diff-6f15e27c3e048b98302b636c2b8f983bR7
I just removed it and it is still working for my
nonebackend.However since this is file is sufficiently complex I cannot
tell what the general consequence of removing is.