Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split About text in smaller parts to prevent unneeded re-translation. #1042

Merged
merged 2 commits into from Nov 18, 2018
Merged

Split About text in smaller parts to prevent unneeded re-translation. #1042

merged 2 commits into from Nov 18, 2018

Conversation

zas
Copy link
Collaborator

@zas zas commented Nov 16, 2018

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

On each new year or when adding a new author, the whole About string has to be translated again.

Solution

Move variable bits outside of it.

Action

@zas zas requested a review from phw November 16, 2018 10:41
phw
phw requested changes Nov 16, 2018
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would only change the naming of flaticon-credits, this seems to be too specific. I would call it just icon-credits or maybe artwork-credits.

@zas
Copy link
Collaborator Author

zas commented Nov 16, 2018

Looks good to me, I would only change the naming of flaticon-credits, this seems to be too specific. I would call it just icon-credits or maybe artwork-credits.

Actually it was intentional, those credits are specific to flaticon, if, in the future, we have to add more icons credits they are likely to be in another set.

phw
phw previously approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the credits for samj1912 do not refer to flaticons, or did I get this wrong? Otherwise I'm fine with this.

@zas
Copy link
Collaborator Author

zas commented Nov 17, 2018

I thought the credits for samj1912 do not refer to flaticons, or did I get this wrong? Otherwise I'm fine with this.

You may be right. @samj1912 ??

@samj1912
Copy link
Collaborator

Yeah, the ones I made are not flat icon ones.

@zas
Copy link
Collaborator Author

zas commented Nov 18, 2018

Yeah, the ones I made are not flat icon ones.

Ok, i changed to icons to be less specific.
I'm not really happy though, i'd like us to be able to output credits to console, but the current stuff is very UI-oriented, with urls, and emails, i may rework this.
About emails, yours isn't displayed because of < and > around it, was it intentionnal ?

@zas zas merged commit 42d206c into metabrainz:master Nov 18, 2018
@zas zas deleted the about_split branch March 30, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zas @samj1912 @phw