Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valentina: don’t copy mailcap file into XDG MIME directory #50449

Merged
merged 1 commit into from Nov 16, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

The mailcap file has no use here (and results in an error from QMimeDatabase trying to parse it) as we already have a sharedmimeinfo file there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry for the noise.

@Mic92 Mic92 merged commit 5632aad into NixOS:master Nov 16, 2018
@jfrankenau jfrankenau deleted the fix-valentina-mailcap branch November 16, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants