Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubber: 1.4 -> 1.5.1 #50320

Merged
merged 1 commit into from Nov 13, 2018
Merged

rubber: 1.4 -> 1.5.1 #50320

merged 1 commit into from Nov 13, 2018

Conversation

stites
Copy link
Member

@stites stites commented Nov 13, 2018 •
edited

Motivation for this change

Version bump.

Things done
  • [?] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS) I think I did this correctly
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) not applicable?
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) I get an error about how I shouldn't evaluate the entire Nixpkgs?? -- not sure how to fix this
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Nov 13, 2018

@GrahamcOfBorg build rubber

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rubber

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1/lib  /nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1/bin
patching script interpreter paths in /nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1
checking for references to /build in /nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1...
wrapping `/nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1/bin/rubber'...
wrapping `/nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1/bin/rubber-info'...
wrapping `/nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1/bin/rubber-pipe'...
running install tests
When a test fails, please remove the tmp directory manually.
OK
/nix/store/hzzxd6qmdlvz20prfj849nyi9xk134fv-rubber-1.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rubber

Partial log (click to expand)

strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1/lib  /nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1/bin
patching script interpreter paths in /nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1
wrapping `/nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1/bin/rubber'...
wrapping `/nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1/bin/rubber-info'...
wrapping `/nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1/bin/rubber-pipe'...
running install tests
When a test fails, please remove the tmp directory manually.
OK
/nix/store/yssaxiblgmjiwaaf3xmxqbpd7vxw0kw3-rubber-1.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rubber

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1/lib  /nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1/bin
patching script interpreter paths in /nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1
checking for references to /build in /nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1...
wrapping `/nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1/bin/rubber'...
wrapping `/nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1/bin/rubber-pipe'...
wrapping `/nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1/bin/rubber-info'...
running install tests
When a test fails, please remove the tmp directory manually.
OK
/nix/store/vvcz0mkljp96l0jnhasz6ka2wiipc6vd-rubber-1.5.1

@timokau
Copy link
Member

timokau commented Nov 13, 2018

Thanks :) ofBorg definitely builds in a sandbox so that is taken care of. nixos tests are indeed not applicable and I'm not sure about the closure size thing but that shouldn't be an issue here.

@timokau timokau merged commit 146eb2a into NixOS:master Nov 13, 2018
@stites stites deleted the rubber-1.5.1 branch November 19, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stites @timokau @GrahamcOfBorg