Fix helm version #50299
Fix helm version #50299
Conversation
| rev = "v${version}"; | ||
| sha256 = "1z810a6mxyrrw4i908dip8aqsj95c0kmv6xpb1wwhskg1zmf85wk"; | ||
| sha256 = "1jjyyidffls0yzi00p7icg19f10wdrmcgb52migdy4kv2chvmrah"; | ||
| leaveDotGit = "true"; |
There was a problem hiding this comment.
The problem about this option is that the checksum can break at any time git decides to change their .git directory layout. Therefore we want to avoid it at all cost.
I would suggest to either write a script instead that generates this information automatically,
like here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/analysis/radare2/default.nix#L92
Or just set the version only, which might be enough in most cases.
There was a problem hiding this comment.
I think you could try to manually set the CommitID with LDFLAGS. See
https://github.com/helm/helm/blob/aa98e7e3dd2356bce72e8e367e8c87e8085c692b/versioning.mk#L25.
We could then use fetchFromGitHub. The drawback is you would have to manually specify both tag and commitId.
Here an example to set LDFLAGS https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/skopeo/default.nix#L33.
There was a problem hiding this comment.
Better doing that manually then going through the leaveDotGit hell.
|
Fixed in #50918 |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Fixes the inability to run
helm initdue to helm using it's own version to pick the version of tiller to fetch. See helm/helm#3770 for more details.