Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.arelle: 2017-08-24 -> 18.3 #50308

Merged
merged 2 commits into from Dec 5, 2018
Merged

pythonPackages.arelle: 2017-08-24 -> 18.3 #50308

merged 2 commits into from Dec 5, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Nov 13, 2018 •
edited

Motivation for this change

Replaces #50269

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Synthetica9
Copy link
Member Author

cc @roberth

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.arelle

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.arelle

Partial log (click to expand)

writing manifest file 'Arelle.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
see log in c:\temp\testLog.txt
pytestcachePhase
/nix/store/jvqp15hrs6a3x5gp7n6wbw07qb71dp47-python3.6-arelle-18.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.arelle

Partial log (click to expand)

writing manifest file 'Arelle.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
see log in c:\temp\testLog.txt
pytestcachePhase
/nix/store/9nh82sq57rbw9snh07xhbbmqy224sqrl-python3.6-arelle-18.3

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python3.pkgs.arelle

Partial log (click to expand)


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
see log in c:\temp\testLog.txt
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/l6ps598pxw38zd42b90nys2lpjx6fdn7-python3.6-arelle-18.3.drv' failed with exit code 1
error: build of '/nix/store/l6ps598pxw38zd42b90nys2lpjx6fdn7-python3.6-arelle-18.3.drv' failed

@dotlambda
Copy link
Member

That's strange. Why are the tests only run on x86_64-linux?

@Synthetica9
Copy link
Member Author

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase.

Tests are actually being ran, but it's not reporting the output. I'll see what I can do

@Synthetica9
Copy link
Member Author

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase.

Tests are actually being ran, but it's not reporting the output. I'll see what I can do

That gave me no end of encoding problems, so the answer seems to be "nothing"

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.arelle

@dotlambda dotlambda removed the request for review from infinisil December 4, 2018 20:13
@dotlambda dotlambda merged commit 8f2d5e6 into NixOS:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @dotlambda @GrahamcOfBorg