Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: apply pruneLibtoolFiles #50296

Closed
wants to merge 1 commit into from
Closed

libvirt: apply pruneLibtoolFiles #50296

wants to merge 1 commit into from

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 13, 2018

Motivation for this change

Withouth this libvirt.la propagates its internal dependencies on libcap-ng and libyajl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej
libvirt: apply pruneLibtoolFiles
91af782 
Otherwise it propagates internal dependencies on libcap-ng and libyajl.
@orivej
Copy link
Contributor Author

orivej commented Nov 13, 2018

@GrahamcOfBorg build libvirt

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libvirt

Partial log (click to expand)

Removing /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share/gtk-doc
rmdir: failed to remove '/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share': Directory not empty
gzipping man pages under /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/lib  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/libexec  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/sbin
patching script interpreter paths in /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
moving /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/sbin/* to /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0...
moving /nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/sbin/* to /nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0/bin
/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

/nix/store/47v7cvhqn25cm3w2ir0ra58i7kxndy5q-libvirt-4.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libvirt

Partial log (click to expand)

Removing /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share/gtk-doc
rmdir: failed to remove '/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share': Directory not empty
gzipping man pages under /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/lib  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/libexec  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin  /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/sbin
patching script interpreter paths in /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
moving /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/sbin/* to /nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0/bin
/nix/store/nhl4721ajvax0yyhz7ysm2v19masqjmx-libvirt-4.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0...
moving /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/sbin/* to /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/bin
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

patching script interpreter paths in /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/libvirt-guests: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/libvirtd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/virtlockd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/var/lib/rc.d/init.d/virtlogd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/libexec/libvirt-guests.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/bin/virt-xml-validate: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0...
moving /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/sbin/* to /nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0/bin
/nix/store/krd29zwnx8mp44khf070p3zk1csxxdl7-libvirt-4.7.0

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@orivej orivej closed this Jun 2, 2020
@orivej
Copy link
Contributor Author

orivej commented Jun 2, 2020

libtool files are already being safely pruned for all packages.

@orivej orivej deleted the libvirt branch March 29, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @mmahut