Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autospotting: init at unstable-2018-11-17 #50313

Closed
wants to merge 1 commit into from
Closed

autospotting: init at unstable-2018-11-17 #50313

wants to merge 1 commit into from

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Nov 13, 2018 •
edited by worldofpeace

Motivation for this change

Init package from @coretemp request. #50304

Things done

autospotting: init at unstable-2018-11-17

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build autospotting

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
shrinking /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin/AutoSpotting
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin
patching script interpreter paths in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
checking for references to /build in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
shrinking /nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin/AutoSpotting
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin
patching script interpreter paths in /nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
checking for references to /build in /nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin

@costrouc
Copy link
Member Author

@coretemp does autospotting work with darwin? I set platforms to linux since that is the only one that I have access to.

Additionally are there any propagatedBuildInputs required for the package?

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

Since you don't seem to use this package, would @coretemp maintain this package?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

/nix/store/1x0r976h1238gnmn309val5ylcg2d1xv-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

@GrahamcOfBorg build autospotting

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
shrinking /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin/AutoSpotting
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin/bin
patching script interpreter paths in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin
checking for references to /build in /nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/hasfkd2v77qw9943p568ph9dbhk78dcz-AutoSpotting-unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587-bin

@coretemp
Copy link
Contributor

I had expected it to take much longer before this was packaged, which is why I request issues a long time before I actually need them. I have other priorities currently.

coretemp
coretemp reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@coretemp coretemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but untested.

@costrouc
Copy link
Member Author

I am not very knowledgeable on building go packages so I don't know much as far as testing them goes.

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

I guess then we can wait until we have a maintainer.

@costrouc
Copy link
Member Author

I am happy to maintain the package. However, I will rely on others to tell me if it is not working.

@coretemp
Copy link
Contributor

Can't we just have some kind of meta data saying it is "experimental"?

@cristim
Copy link

cristim commented Nov 14, 2018

@costrouc to answer your question about darwin and other Linux systems: as the initial author of AutoSpotting and current maintainer I can confirm that it builds fine on Ubuntu, which is what I use for development on a daily basis. Last time I checked it also worked on macOS, and I know of one of the other contributors who uses macOS on a daily basis.

@costrouc costrouc changed the title autospotting: init at unstable-acbadb09a0ab2c2d3f5dcc984594f65d7904d587 autospotting: init at unstable-2018-11-17 Nov 20, 2018
@costrouc
Copy link
Member Author

@cristim glad to meet the original author! Happy to maintain this package on nixpkgs as I think there will be enough feedback from the community if things are not working.

Lets get this merged -- I have kept myself as a maintainer.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin
shrinking /nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin/bin/AutoSpotting
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin/bin
patching script interpreter paths in /nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin
checking for references to /build in /nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/z9fffa9ylrv5l6f3vhsl1js5sqg6am6y-AutoSpotting-unstable-2018-11-17-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: autospotting

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin
shrinking /nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin/bin/AutoSpotting
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin/bin
patching script interpreter paths in /nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin
checking for references to /build in /nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/awr6zjpk3agifgc9bg05a5gp5i12pph7-AutoSpotting-unstable-2018-11-17-bin

@worldofpeace
Copy link
Contributor

@costrouc I've brought this to master with 67a4067. Just had apply a nitpick 😄

Thanks for extending yourself ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretemp coretemp coretemp left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@costrouc @GrahamcOfBorg @Mic92 @coretemp @cristim @worldofpeace @FRidh