libredirect: misc changes #50302
Merged
libredirect: misc changes #50302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces a bit of duplication and can also be used from the outside:
export LD_PRELOAD=${libredirect}/lib/${libredirect.libName}
|
Success on x86_64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libredirect Partial log (click to expand)
|
aszlig
approved these changes
Nov 13, 2018
| @@ -8,30 +8,40 @@ stdenv.mkDerivation { | |||
| cp ${./test.c} test.c | |||
| ''; | |||
|
|
|||
| shlibext = stdenv.targetPlatform.extensions.sharedLibrary; | |||
| libName = "libredirect" + stdenv.targetPlatform.extensions.sharedLibrary; | |||
|
@LnL7 addressed your comment as well |
|
@aszlig good idea about { libredirect, myprogram, iana-etc }:
libredirect.wrapWith {
bin = "${myprogram}";
redirects = {
"/etc/protocols" = "${iana-etc}/etc/protocols";
};
}but then it's not very composable |
|
Success on x86_64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libredirect Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
LnL7
reviewed
Nov 13, 2018
zimbatm
force-pushed
the
libredirect-misc
branch
from
c36ea37
to
82bea76
Compare
|
Success on aarch64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
LnL7
approved these changes
Nov 13, 2018
This allows to simplify the usage of libredirect inside of nix build sandboxes. Add "libredirect.hook" to the build inputs to get everything linked in automaticall. All that's left is to set NIX_REDIRECTS and call the target program.
zimbatm
force-pushed
the
libredirect-misc
branch
from
82bea76
to
d04a126
Compare
|
Success on x86_64-darwin (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libredirect Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make libredirect a bit more easy to use
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)