Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] jackett: 0.10.365 -> 0.10.434 #50309

Merged
merged 2 commits into from Nov 13, 2018
Merged

[18.09] jackett: 0.10.365 -> 0.10.434 #50309

merged 2 commits into from Nov 13, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 13, 2018 •
edited

Motivation for this change

See #50306 for upstream PR

Multiple fixes, notably YGGtorrent url change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

r-ryantm and others added 2 commits November 13, 2018 14:17
@r-ryantm @nyanloutre
jackett: 0.10.365 -> 0.10.420
57809e3 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/jackett/versions

(cherry picked from commit 2af7527)
@nyanloutre
jackett: 0.10.420 -> 0.10.434
a97fe12 
(cherry picked from commit 2ae0b2e)
@nyanloutre nyanloutre changed the title jackett: 0.10.365 -> 0.10.434 [18.09] jackett: 0.10.365 -> 0.10.434 Nov 13, 2018
@timokau
Copy link
Member

timokau commented Nov 13, 2018

Does this really only include fixes or are there also potentially breaking changes?

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

For applications that do depend on external services like this one, backporting seems like a good idea because it will also break if we not update it.

@timokau
Copy link
Member

timokau commented Nov 13, 2018

Makes sense.

@timokau timokau merged commit 0f21a3e into NixOS:release-18.09 Nov 13, 2018
@nyanloutre nyanloutre deleted the jackett-434-18-09 branch November 20, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanloutre @timokau @Mic92 @GrahamcOfBorg @r-ryantm