Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot: init at 0.2.17 #51569

Merged
merged 1 commit into from Dec 9, 2018
Merged

polkadot: init at 0.2.17 #51569

merged 1 commit into from Dec 9, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented Dec 5, 2018 •
edited

Motivation for this change

Implementation of a https://polkadot.network node in Rust.
https://github.com/paritytech/polkadot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb
srhb requested changes Dec 6, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/applications/altcoins/polkadot/default.nix Outdated Show resolved Hide resolved
pkgs/applications/altcoins/polkadot/default.nix Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Dec 7, 2018

@GrahamcOfBorg build polkadot

@akru
Copy link
Contributor Author

akru commented Dec 8, 2018

According to #46362 patch with vendored sources is no more reuired.

@akru
Copy link
Contributor Author

akru commented Dec 8, 2018

@GrahamcOfBorg build polkadot

@srhb srhb merged commit 8b11a8a into NixOS:master Dec 9, 2018
@akru akru deleted the polkadot branch April 18, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akru @srhb @GrahamcOfBorg