Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.1.6 -> 2.1.9; parity-beta: 2.2.1 -> 2.2.4 #51568

Merged
merged 2 commits into from Dec 9, 2018
Merged

parity: 2.1.6 -> 2.1.9; parity-beta: 2.2.1 -> 2.2.4 #51568

merged 2 commits into from Dec 9, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented Dec 5, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Dec 6, 2018

@GrahamcOfBorg build parity-beta

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build parity

@worldofpeace
Copy link
Contributor

Do the vendor patches need any changes since daemonize is now from crates.io?

@akru akru changed the title parity: 2.1.6 -> 2.1.8; parity-beta: 2.2.1 -> 2.2.3 parity: 2.1.6 -> 2.1.9; parity-beta: 2.2.1 -> 2.2.4 Dec 7, 2018
@akru
Copy link
Contributor Author

akru commented Dec 7, 2018

@worldofpeace You are right, fixed.

@akru
Copy link
Contributor Author

akru commented Dec 8, 2018

@GrahamcOfBorg build parity parity-beta

worldofpeace
worldofpeace approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed with success. We're good for merge.

@worldofpeace
Copy link
Contributor

@akru Can you split your commit parity: 2.1.6 -> 2.1.9; parity-beta: 2.2.1 -> 2.2.4 into two?

@Mic92
Copy link
Member

Mic92 commented Dec 8, 2018 •
edited

Are cargo/config files still necessary with #46362 ?

@akru
Copy link
Contributor Author

akru commented Dec 8, 2018

@Mic92 You are right, fixed.

@akru
Copy link
Contributor Author

akru commented Dec 8, 2018

@GrahamcOfBorg build parity parity-beta

@srhb srhb merged commit 66829ce into NixOS:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akru @srhb @worldofpeace @Mic92 @GrahamcOfBorg