Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the crew training feature less complex #925

Closed
wants to merge 1 commit into from
Closed

Make the crew training feature less complex #925

wants to merge 1 commit into from

Conversation

siimav
Copy link
Contributor

@siimav siimav commented Dec 4, 2018

Based on the feedback of RO Discord, make proficiency trainings no longer expire and remove mission trainings. This commit also removes all code that's related to training expirations.

Test DLLs are available here: https://github.com/siimav/RP-0/releases/tag/dev3
But be sure to back up your save before loading a game with these DLLs.
It looks like my changes will cause the training expiration blocks to be removed from saves. So even after going back to old DLLs, all trainings would still lack expiration dates.

* Removed mission trainings
@pap1723 pap1723 closed this Dec 11, 2018
@pap1723 pap1723 reopened this Dec 11, 2018
@NathanKell
Copy link
Member

hashtag DELURK Quick note: I think proficiency training not expiring makes a lot of sense, but I'm leery of removing mission training because the point of having it at all is so that you can't do instant launches. In particular, without mission training, it's possible to keep a built LV ready to go on the pad and launch a rescue (or other crewed mission) just-in-time, rather than having to plan ahead.

What's the major gripes people have with mission training?

@RoboRay
Copy link

RoboRay commented Dec 12, 2018

The only issue I have with Mission Training is that I can't schedule it to begin on a specified future date... I can only start it now.

If it's July and a vehicle will be ready to roll out in mid October, I have to be careful to not blow past the date I need to start training on, or manually set up a KAC reminder. In reality, I would just tell the crew and instructors in July to start training in early October and not need to worry about that anymore.

If the training system could generate KAC or stock event system reminders, that would help eliminate the need to babysit the calendar while timewarping or doing other missions.

I do find that Mission Training adds another layer of planning to the game and think it's worth saving. I just find it tedious to use as implemented right now.

@lpgagnon
Copy link
Contributor

lpgagnon commented Dec 14, 2018

For me, the worst feature of mission training is that it gets lost on a launch failure. Now that launchpad ignition failures can be disabled, that's greatly mitigated; but it still makes no sense to me that the astronauts need to train again for the "same" mission if the first one only gets 2km up.

@NathanKell
Copy link
Member

NathanKell commented Dec 14, 2018 via email

@pap1723
Copy link
Contributor

pap1723 commented Dec 14, 2018

@NathanKell here is a different approach to the question...Looking at the code, you pretty much already have the constraints built in with the Training Time limit of (is it 120?) days and also the mandatory inactivity period afterwards. If the flight is very short, the inactivity period will be short and they will be able to fly again since the inactiveTime is:

double inactiveTime = elapsedTime * multiplier + constant * 86400d;

I think having training expire just because a mission is accomplished doesn't make sense. Instead, we should leave the expiration date to the current setting and get rid rid of the removal of training proficiency upon recovery. So I think we should remove this section completely:

if (e.type == "TRAINING_mission:)
   SetExpiration(pcm.name, e, Planetarium.GetUniversalTime());

@pap1723
Copy link
Contributor

pap1723 commented Dec 14, 2018

Proficiency is also something that can be set by the config file if I remember correctly? I think we should move the proficiency expiration dates into the RP-0 Settings Fields so if people want to, they can set it to much different values if they would like.

@pap1723 pap1723 mentioned this pull request Dec 14, 2018
@pap1723
Copy link
Contributor

pap1723 commented Dec 14, 2018

Closing this for now, please see issue #942 to continue discussion.

@pap1723 pap1723 closed this Dec 14, 2018
@siimav siimav deleted the RemoveRefresher branch December 30, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants