I think it'd be interesting to have either this or #57419 merged by 19.09, so that newer apple laptops can be made more reasonably usable. Though, I think this PR is more appropriate, as it also adds an option to make it more usable.

Adding this one to the 19.09 milestone; the conflicts are likely trivial (module-list, all-packages), meaning that any nixpkgs contributor can fix it by that time. Hopefully one who can test the change.

apparently as of the upcoming v5.3 kernel release, the driver has been upstreamed and merged into the kernel? making this PR partially unnecessary as long as it is built into the kernel as a module.
torvalds/linux@038b1a0#diff-21f587dcb9b25ed3dcff9dade6b0aa67

I do no longer actively use nixos (or any linux for that matter) on my macbook anymore, but I would be willing to test the upstreamed driver and re-visit this PR.

(also, on another note, the original cb22 driver seems to be unmaintained, but roadrunner2's fork seems to be actively worked on)

oh yeah; I almost forgot, only on macbook8,1 (that is the 2015 12-inch macbook), resume from standby still doesn't work as the driver locks up (last time I tried it out was about a month ago; could theoretically be fixed)

No worries, I was triaging random PRs.

At least the current status of this PR is known, anyone wanting to take it up now knows.

I think this can be closed as #71812 landed in master.

Yep, I agree with you. Applespi seems to have landed in the mainline kernel.