prometheus/exporters: fix DynamicUser regression #51545
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WilliButz FYI |
|
Also note that the regression was cherry-picked onto release-18.09 in 7277b1d. The fix probably should be applied there as well since it's a security/defense in depth regression and violates the behavior described by the module documentation. |
GrahamcOfBorg
added
6.topic: nixos
delroth
force-pushed
the
prometheus-exporters-dynamicuser
branch
2 times, most recently
from
ffc6334 to
964a3e8
Compare
Instead of setting User/Group only when DynamicUser is disabled, the previous version of the code set it only when it was enabled. This caused services with DynamicUser enabled to actually run as nobody, and services without DynamicUser enabled to run as root. Regression from fbb7e0c.
delroth
force-pushed
the
prometheus-exporters-dynamicuser
branch
from
964a3e8 to
10041e7
Compare
globin
approved these changes
Dec 5, 2018
|
@delroth Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fbb7e0c inverted logic related to DynamicUser. Instead of setting User/Group when DynamicUser is disabled, it is only set when DynamicUser is enabled. This causes DynamicUser exporters to run as nobody/nobody, and other exporters to run as root.
prometheus/exporters/tor happens to not work with DynamicUser as is because of a CPython bug, so a prerequisite commit works around the issue by defining a dummy $HOME.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)