Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skhd: 0.2.2 -> 0.3.0 #51549

Merged
merged 1 commit into from Dec 5, 2018
Merged

skhd: 0.2.2 -> 0.3.0 #51549

merged 1 commit into from Dec 5, 2018

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Dec 5, 2018

Motivation for this change

Update to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Dec 5, 2018

/cc @LnL7

@rasendubi
Copy link
Member

@GrahamcOfBorg build skhd

@Mic92 Mic92 merged commit b2c86f4 into NixOS:master Dec 5, 2018
@LnL7
Copy link
Member

LnL7 commented Dec 6, 2018

Thanks!

@periklis
Copy link
Contributor

periklis commented Dec 7, 2018

Many thanks @yurrriq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yurrriq @rasendubi @LnL7 @periklis @Mic92 @GrahamcOfBorg