Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.svgwrite: 1.1.6 -> 1.2.1 #51542

Merged
merged 3 commits into from Dec 5, 2018
Merged

pythonPackages.svgwrite: 1.1.6 -> 1.2.1 #51542

merged 3 commits into from Dec 5, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 5, 2018

Motivation for this change

Fixes #51512

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 5, 2018 02:42
@marsam
Copy link
Contributor Author

marsam commented Dec 5, 2018

I've included c564ca8 and e728f2d, because nix-review showed that those packages were affected; please tell me if I need to create separate PRs for them.

@rasendubi
Copy link
Member

@GrahamcOfBorg build python3Packages.cairosvg python3Packages.qasm2image python3Packages.svgwrite

@rasendubi rasendubi merged commit d5090fe into NixOS:master Dec 5, 2018
@marsam marsam deleted the feature/update-python-svgwrite branch December 5, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @rasendubi @GrahamcOfBorg