opensans-ttf: change source to salsa, rename to open-sans #51529
+35
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
commented
Dec 4, 2018
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "open-sans"; | ||
| version = "1.11"; |
There was a problem hiding this comment.
This version has been noted in their repository.
worldofpeace
commented
Dec 4, 2018
GrahamcOfBorg
added
8.has: clean-up
8.has: package (new)
c0bw3b
reviewed
Dec 5, 2018
worldofpeace
force-pushed
the
open-sans/different-source
branch
from
e78918b to
47d2b89
Compare
|
Tested locally too. A quick diff between some TTF from Debian and the current archives' content from https://www.opensans.com/ shows it's the same files. |
worldofpeace
force-pushed
the
open-sans/different-source
branch
from
47d2b89 to
f5e664f
Compare
|
Oh just noticed that we'll be losing the hebrew fonts by switching. Though they should probably be added as a separate package |
c0bw3b
approved these changes
Dec 5, 2018
Yes it's another font made by some else so it would be another derivation for nixpkgs (IMHO) |
|
Just double checking the fetching: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We really shouldn't be fetching this from a web archive.
This also includes the condensed variant.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)