Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensans-ttf: change source to salsa, rename to open-sans #51529

Merged
merged 1 commit into from Dec 5, 2018
Merged

opensans-ttf: change source to salsa, rename to open-sans #51529

merged 1 commit into from Dec 5, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Dec 4, 2018 •
edited

Motivation for this change

We really shouldn't be fetching this from a web archive.

This also includes the condensed variant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace commented Dec 4, 2018
View reviewed changes
pkgs/data/fonts/open-sans/default.nix

stdenv.mkDerivation rec {
pname = "open-sans";
version = "1.11";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version has been noted in their repository.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018 •
edited

Tested locally too. A quick diff between some TTF from Debian and the current archives' content from https://www.opensans.com/ shows it's the same files.
But I'd rather fetch from the Salsa tag. More stable over time I guess.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Dec 5, 2018 •
edited

Oh just noticed that we'll be losing the hebrew fonts by switching.

Though they should probably be added as a separate package open-sans-hebrew.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

Though they should probably be added as a separate package open-sans-hebrew.

Yes it's another font made by some else so it would be another derivation for nixpkgs (IMHO)

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

Just double checking the fetching:
@GrahamcOfBorg build open-sans

@c0bw3b c0bw3b merged commit 75fe537 into NixOS:master Dec 5, 2018
@worldofpeace worldofpeace deleted the open-sans/different-source branch December 5, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @c0bw3b @GrahamcOfBorg