[18.09] prometheus/exporters: fix regression in DynamicUser behavior #51560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting User/Group only when DynamicUser is disabled, the previous version of the code set it only when it was enabled. This caused services with DynamicUser enabled to actually run as nobody, and services without DynamicUser enabled to run as root. Regression from fbb7e0c. (cherry picked from commit 10041e7)
|
(cc @globin -- not sure if you were planning to do it on your own, so here's a PR for convenience) |
|
Yes, sorry just did it myself, noticing this too late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #51545 onto 18.09.