Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reptyr: 0.6.2 -> 0.7.0 #51552

Merged
merged 1 commit into from Dec 5, 2018
Merged

reptyr: 0.6.2 -> 0.7.0 #51552

merged 1 commit into from Dec 5, 2018

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Update reptyr to the latest version. This release adds support for aarch64-linux, and removes the need for the build system workarounds.

Things done

I added aarch64-linux to the supported platforms and also explicitly listed all the supported ARM platforms. I changed it to use lib.platforms.arm in #51259, but since then I decided that it would probably be better to explicitly list out the supported platforms, since reptyr would not work on aarch64-freebsd (hypothetically - we currently don't support that system), but it would be part of lib.platforms.arm.

I also enabled the tests.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build reptyr

@7c6f434c 7c6f434c merged commit be1d5e8 into NixOS:master Dec 5, 2018
@lopsided98 lopsided98 deleted the reptyr-update branch December 5, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants