Skip to content

(JavaFXSceneBuilder): Init at version 2 #51564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

(JavaFXSceneBuilder): Init at version 2 #51564

wants to merge 3 commits into from
+71 −0

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Dec 5, 2018

Motivation for this change

Add JavaFXSceneBuilder to be used standalone or inside intellij or other IDEs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ysndr ysndr force-pushed the new/javafx-scene-builder branch from 2fd877f to 9e3a237 Compare December 5, 2018 16:25
matthewbauer
matthewbauer reviewed Dec 19, 2018
View reviewed changes
pkgs/applications/editors/javafx-scene-builder/default.nix Outdated
SceneBuilder cannot be downloaded without license acception.
1. Download a copy from https://www.oracle.com/technetwork/java/javase/downloads/javafxscenebuilder-1x-archive-2199384.html
2. In a shell, execute:
nix-prefetch-url file:///path/to/Xcode_7.2.dmg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update this text for javascenebuilder

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Are there any updates on this pull request, please?

@ysndr
Copy link
Member Author

ysndr commented Aug 12, 2019

Have not been in need of this since then and have totally forgotten about it. I'll look into this. I think the only issue has been the description. Now, maybe a fresh rebase might be needed, but apart from that this should be fine.

@ysndr
Copy link
Member Author

ysndr commented Aug 12, 2019

Actually autoPatchelf is not able to find libavcodec.so.53 and libavformat.so.53. Any idea how to include those? Neither importing ffmpeg nor libav respectively would fix this. 🤔

ryantm
ryantm requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this package is causing an evaluation error with ofborg. So that needs to be resolved.

The library issue looks similar to what is going on here:

nixpkgs/pkgs/applications/audio/spotify/default.nix

Line 126 in 9842c4b

ln -s ${ffmpeg_3.out}/lib/libavcodec.so* $libdir

pkgs/applications/editors/javafx-scene-builder/default.nix
stdenv.mkDerivation rec {
pname = "JavaSceneBuilder";
version = "2_0";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "${pname}-${version}";

@ysndr @ryantm
Accept corrected spelling
108263b 
Co-Authored-By: Ryan Mulligan <ryan@ryantm.com>
@ysndr
Copy link
Member Author

ysndr commented Feb 15, 2020 •
edited
Loading

I see that oracle now requires one to register an account on order to download the scene builder. I also wonder if this program is even used that broadly? If not I think this PR could be closed, and I might look into packaging gluon instead if there is interest.

@mmahut you seemed to have an interest in this program once, what do you think?

@ShamrockLee
Copy link
Contributor

As far as I know, SceneBuilder is now distributed under the 3-clause BSD License on GitHub, and the installers can also be downloaded from the official website directly (without registrations or something similar).
GitHub page: gluonhq/scenebuilder
Home page: https://gluonhq.com/products/scene-builder/
It would be awsome to have it as a Nix package.

@ShamrockLee ShamrockLee mentioned this pull request Jun 13, 2020
Closed
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@wirew0rm wirew0rm mentioned this pull request Jan 21, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Replaced by #110398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer

@ryantm ryantm

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ysndr @mmahut @ShamrockLee @SuperSandro2000 @ryantm @matthewbauer @GrahamcOfBorg