Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustCreate: export RUSTDOC during cargo config #51536

Merged
merged 1 commit into from Dec 5, 2018
Merged

buildRustCreate: export RUSTDOC during cargo config #51536

merged 1 commit into from Dec 5, 2018

Conversation

thoughtpolice
Copy link
Member

See #50452 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice
buildRustCreate: export RUSTDOC during cargo config
6c5279b 
See NixOS#50452 (comment)

Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice self-assigned this Dec 5, 2018
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build carnix

@thoughtpolice thoughtpolice merged commit 3aa9091 into NixOS:master Dec 5, 2018
@thoughtpolice thoughtpolice deleted the nixpkgs/add-rustdoc-env branch January 12, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thoughtpolice thoughtpolice

Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @GrahamcOfBorg