Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgconf: init at 1.5.4 #50771

Merged
merged 4 commits into from Nov 20, 2018
Merged

pkgconf: init at 1.5.4 #50771

merged 4 commits into from Nov 20, 2018

Conversation

zaninime
Copy link
Contributor

Motivation for this change

Add a new derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zaninime zaninime mentioned this pull request Nov 19, 2018
Closed
9 tasks
jtojnar
jtojnar reviewed Nov 19, 2018
View reviewed changes
pkgs/development/tools/misc/pkgconf/default.nix

meta = with stdenv.lib; {
description = "Package compiler and linker metadata toolkit";
homepage = https://git.dereferenced.org/pkgconf/pkgconf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pkgconf.org/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website is clearly out-of-date and returns an invalid HTTPS certificate. I would recommend against linking it in the derivation. It also points to GitHub, which is not the official repository any longer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more concerns on this? The rest should be fixed.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 20, 2018 via email

@zaninime
Copy link
Contributor Author

Could you try reporting the broken website in their issue tracker?

https://git.dereferenced.org/pkgconf/pkgconf/issues/16

I will follow up on this if any news comes by. Should this PR be merged anyway, and I submit a new one when / if further information is available?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 20, 2018

@GrahamcOfBorg build pkgconf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pkgconf

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4
shrinking /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4/bin/pkgconf
shrinking /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4/lib/libpkgconf.so.3.0.0
gzipping man pages under /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4/lib  /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4/bin
patching script interpreter paths in /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4
checking for references to /build in /nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4...
/nix/store/27d287bsvamhyxdpwff5la363w366rgi-pkgconf-1.5.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pkgconf

Partial log (click to expand)

 /nix/store/x005987xqwcb89w7103xnqr7y2m934fx-coreutils-8.30/bin/install -c -m 644  libpkgconf/bsdstubs.h libpkgconf/iter.h libpkgconf/libpkgconf.h libpkgconf/stdinc.h libpkgconf/libpkgconf-api.h '/nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/include/pkgconf/libpkgconf'
 /nix/store/x005987xqwcb89w7103xnqr7y2m934fx-coreutils-8.30/bin/mkdir -p '/nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/lib/pkgconfig'
 /nix/store/x005987xqwcb89w7103xnqr7y2m934fx-coreutils-8.30/bin/install -c -m 644 libpkgconf.pc '/nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/lib/pkgconfig'
make[1]: Leaving directory '/private/tmp/nix-build-pkgconf-1.5.4.drv-0/pkgconf-1.5.4'
post-installation fixup
gzipping man pages under /nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/share/man/
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/lib  /nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4/bin
patching script interpreter paths in /nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4
/nix/store/29f49jn9p7rcc1hi15cjd9f7vhjq9m4g-pkgconf-1.5.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgconf

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4
shrinking /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/bin/pkgconf
shrinking /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/lib/libpkgconf.so.3.0.0
gzipping man pages under /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/lib  /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/bin
patching script interpreter paths in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4
checking for references to /build in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4...
/nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4

@jtojnar jtojnar merged commit 75fc7b5 into NixOS:master Nov 20, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Nov 20, 2018

Thanks. we will fix the website when they respond.

@zaninime zaninime deleted the pkgconf branch March 31, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zaninime @jtojnar @GrahamcOfBorg @Janik-Haag