Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nspr cross compilation #50807

Closed
wants to merge 2 commits into from
Closed

Fix nspr cross compilation #50807

wants to merge 2 commits into from

Conversation

eburimu
Copy link
Contributor

@eburimu eburimu commented Nov 20, 2018

Motivation for this change

See: #50656
ping @exarkun

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eburimu eburimu closed this Nov 20, 2018
@eburimu eburimu deleted the fix/nspr branch November 20, 2018 00:05
@eburimu
Copy link
Contributor Author

eburimu commented Nov 20, 2018 •
edited

See 4d10fb3

@eburimu eburimu mentioned this pull request Nov 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eburimu @GrahamcOfBorg