Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.generic-lens: apply patch to fix tests #50806

Merged
merged 1 commit into from Nov 20, 2018
Merged

haskellPackages.generic-lens: apply patch to fix tests #50806

merged 1 commit into from Nov 20, 2018

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

There was an issue with the test suite for the haskell generic-lens package. A patch for this was included in master after the 18.09 release. Cherry pick this into 18.09 so generic-lens becomes usable there too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@twhitehead twhitehead mentioned this pull request Nov 20, 2018
Closed
@peti
Copy link
Member

peti commented Nov 20, 2018

Does master need that patch, too?

@twhitehead
Copy link
Contributor Author

Master is good. I cherry-picked it from there. :)

@peti
Copy link
Member

peti commented Nov 20, 2018 via email

@twhitehead
Copy link
Contributor Author

Ok. I've re-picked with -x. Thanks for the tip.

@peti peti merged commit 03dc647 into NixOS:release-18.09 Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twhitehead @peti @GrahamcOfBorg