Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyupdate: init at 0.2.16 #50817

Merged
merged 1 commit into from Nov 26, 2018
Merged

pythonPackages.pyupdate: init at 0.2.16 #50817

merged 1 commit into from Nov 26, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

This is needed for the HA custom_updater card.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Cc @dotlambda

dotlambda
dotlambda requested changes Nov 20, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by setup.py, this needs a disabled = !isPy3k.

@peterhoeg
Copy link
Member Author

I did a nix-build python2Packages.pyupdate and it was fine but pyupdate is specific to HA and as that's py3 only, I guess we might as well limit it.

dotlambda
dotlambda reviewed Nov 21, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -196,7 +196,7 @@ in {

astropy = callPackage ../development/python-modules/astropy { };

astroquery = callPackage ../development/python-modules/astroquery { };
astroquery = callPackage ../development/python-modules/astroquery { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dotlambda dotlambda merged commit 1ec18b0 into NixOS:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @dotlambda @GrahamcOfBorg