Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsv: Add darwin.Security as dependency on MacOS #50836

Merged
merged 2 commits into from Nov 21, 2018
Merged

xsv: Add darwin.Security as dependency on MacOS #50836

merged 2 commits into from Nov 21, 2018

Conversation

daniels
Copy link
Contributor

@daniels daniels commented Nov 20, 2018

Motivation for this change

xsv failed to build for me on MacOS 10.13.6 after upgrading the channel nixpkgs-unstable. I also attempted to build it from master with the same error:

error: linking with `/nix/store/l928iaj0m48lfb7dib6h7p22d50l566x-clang-wrapper-5.0.2/bin/cc` failed: exit code: 1 
|
  = note: "/nix/store/l928iaj0m48lfb7dib6h7p22d50l566x-clang-wrapper-5.0.2/bin/cc" "-m64" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.0.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.1.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.10.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.11.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.12.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.13.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.14.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.15.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.2.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.3.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.4.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.5.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.6.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.7.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.8.rcgu.o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.serde_derive.ektx1vlp-cgu.9.rcgu.o" "-o" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/libserde_derive-8479381264722504.dylib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/serde_derive-8479381264722504.5b5pnbs7ysgi257p.rcgu.o" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/libsyn-1dc782ec30bc4245.rlib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/libquote-85bceeed12796714.rlib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/libproc_macro2-84d8f71df10ed916.rlib" "/private/tmp/nix-build-xsv-0.13.0.drv-0/source/target/release/deps/libunicode_xid-3e48e37f11f82db2.rlib" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lproc_macro-3c3310d56327c751" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lsyntax-5804bc44f6aa386c" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lrustc_target-9b72dc107559762c" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lrustc_errors-4eab085f8d21579c" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lsyntax_pos-af163bbd2a3b6cd4" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-larena-640d3352917efd05" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lrustc_data_structures-2444c86d41a6f566" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lrustc_cratesio_shim-89f003a3cf6a0f50" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lserialize-48f4ceb2315fb290" "-L" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib" "-lstd-8b3bb8561e753cc3" "/nix/store/9mlgmipqar210mkaiqz3c5il0lxdyrl6-rustc-1.30.0/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-b360031db1b4c6a3.rlib" "-framework" "Security" "-lSystem" "-lresolv" "-lpthread" "-lc" "-lm" "-dynamiclib" "-Wl,-dylib"
  = note: ld: framework not found Security
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `serde_derive`.

To learn more, run the command again with --verbose.
builder for '/nix/store/rw0gwasxkdnvcjzwy7y10b5s8yafq5m2-xsv-0.13.0.drv' failed with exit code 101

Please note that I'm way in over my head here – I don't know anything about buildRustPackage and very little about nix. But with this addition it builds, at least for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Nov 21, 2018

@GrahamcOfBorg build xsv

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xsv

Partial log (click to expand)

these paths will be fetched (0.62 MiB download, 2.53 MiB unpacked):
  /nix/store/nlz2mz2h53r8b6vhr30kdjhf8f7gsb6x-xsv-0.13.0
copying path '/nix/store/nlz2mz2h53r8b6vhr30kdjhf8f7gsb6x-xsv-0.13.0' from 'https://cache.nixos.org'...
/nix/store/nlz2mz2h53r8b6vhr30kdjhf8f7gsb6x-xsv-0.13.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xsv

Partial log (click to expand)

these paths will be fetched (0.80 MiB download, 2.97 MiB unpacked):
  /nix/store/xkrj6cprarig9h33yd418qlb6ar91qi2-xsv-0.13.0
copying path '/nix/store/xkrj6cprarig9h33yd418qlb6ar91qi2-xsv-0.13.0' from 'https://cache.nixos.org'...
/nix/store/xkrj6cprarig9h33yd418qlb6ar91qi2-xsv-0.13.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: xsv

Partial log (click to expand)

test test_table::table ... ok

test result: ok. 422 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kwamm9f9lw5j4mg1ma3nk4q5804ns65n-xsv-0.13.0/bin
patching script interpreter paths in /nix/store/kwamm9f9lw5j4mg1ma3nk4q5804ns65n-xsv-0.13.0
/nix/store/kwamm9f9lw5j4mg1ma3nk4q5804ns65n-xsv-0.13.0

@LnL7 LnL7 merged commit ed97417 into NixOS:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniels @LnL7 @GrahamcOfBorg