Skip to content

doc/reviewing-contributions: fix build error #50820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Nov 20, 2018

Regression from #50674. Section IDs cannot contain spaces.

Motivation for this change

https://hydra.nixos.org/build/84345439

Tested fix with a local nix-build, fails at HEAD, works after this PR.

Regression from NixOS#50674. Section IDs cannot contain spaces.
@delroth
Copy link
Contributor Author

delroth commented Nov 20, 2018

(@matthewbauer FYI)

@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 20, 2018
@srhb
Copy link
Contributor

srhb commented Nov 20, 2018

Verified that it builds locally.

@srhb srhb merged commit ff26cc0 into NixOS:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants