termonad: Add wrapper #50810
Merged
termonad: Add wrapper #50810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeQuissimus
force-pushed
the
termonad
branch
from
c5f2cb5
to
12c32cf
Compare
|
Failure on x86_64-darwin (full log) Attempted: termonad Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: termonad Partial log (click to expand)
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: termonad Partial log (click to expand)
|
pkgs/top-level/all-packages.nix
Outdated
| @@ -6483,6 +6483,11 @@ with pkgs; | |||
|
|
|||
| rush = callPackage ../shells/rush { }; | |||
|
|
|||
| termonad = callPackage ../shells/termonad { | |||
There was a problem hiding this comment.
This should probably not be placed in the section with other shells, but instead with other terminal emulators. It should go near where roxterm, sakura, etc are defined.
There was a problem hiding this comment.
Also, I think this should maybe be called termonad-with-packages (to match the xmonad-with-packages derivation).
Or, maybe keep this as termonad and at some point try to get xmonad-with-packages to be called just xmonad. I think this would be the better solution, but there will probably be some pushback from people who have been using xmonad-with-packages for a long time.
There was a problem hiding this comment.
I'll move it.
I figured if you wanted "termonad-without-packages", you could just grab it from "haskellPackages", so no need to suffix it.
There was a problem hiding this comment.
Yeah, I think termonad is the better name as well.
However, in this case I think it might be better to keep a similar naming scheme with other similar packages (xmonad-with-packages is the only one I know of), rather than using something different.
There was a problem hiding this comment.
I'll rename it and then I think we should be good to go
pkgs/shells/termonad/default.nix
Outdated
| @@ -0,0 +1,19 @@ | |||
| { stdenv, ghcWithPackages, makeWrapper, packages }: | |||
There was a problem hiding this comment.
It would be great to have a default argument on packages. Something like (pkgSet: []). That way people wouldn't necessarily have to give a packages argument.
It would also be nice to have a little documentation at the top of this file explaining what the packages argument is and some examples of passing stuff to it.
I'd say most(?) Termonad users will want the colour and lens packages to be available for use in their Termonad config file.
There was a problem hiding this comment.
I want to avoid people pulling in packages they don't need.
If you need colour and lens, you know it and can add them :)
I'll default to an empty list.
|
@NeQuissimus Thanks for putting together this PR! |
|
@jtojnar Okay, that sounds great! Thanks for your work on the gnome stuff. |
NeQuissimus
force-pushed
the
termonad
branch
from
12c32cf
to
1934ba3
Compare
|
Success on x86_64-linux (full log) Attempted: termonad Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: termonad Partial log (click to expand)
|
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: termonad Partial log (click to expand)
|
NeQuissimus
force-pushed
the
termonad
branch
from
1934ba3
to
3dd96c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes cdepillabout/termonad#34
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @cdepillabout @puffnfresh