pkgs/test/nixos-functions: use dummy versioning #50774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this OfBorg and similar tools won't report this derivation as changed every single time.
|
OfBorg looks at derivation paths, not versions. |
|
But those variables influence drvpath and outpath of the NixOS top-level system derivation, which influences the derivation paths of those tests. If you look at what OfBorg reports lately, you'll notice that it reports 1-10 linux changes for noop PRs. This will fix that. |
|
Let's see; would be funny if it affects NixOS/ofborg#273 too… |
|
I think that's unlikely. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this OfBorg and similar tools won't report this derivation as changed every single time.
/cc @Mic92 who can now unblacklist it in
nix-review:)