Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easysnap: 2018-10-28 -> 2018-11-20 #50830

Merged
merged 2 commits into from Nov 21, 2018
Merged

easysnap: 2018-10-28 -> 2018-11-20 #50830

merged 2 commits into from Nov 21, 2018

Conversation

sjau
Copy link

@sjau sjau commented Nov 20, 2018

Motivation for this change

Easysnap Update: Adding some fixes and removing some unnecessary stuff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

timokau
timokau requested changes Nov 20, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the version accordingly (to unstable-2018-11-20) and fix the commit message (version_before -> new_version).

@sjau
Copy link
Author

sjau commented Nov 21, 2018

Applied the suggested changes.

@timokau timokau changed the title easysnap: init -> 2018-11-20 easysnap: 2018-10-28 -> 2018-11-20 Nov 21, 2018
@timokau
Copy link
Member

timokau commented Nov 21, 2018

You now have pushed two separate commits. In the future you can change the commit message with git commit --amend. This time I can just fix it with a squash&merge.

@GrahamcOfBorg build easysnap

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20/bin
patching script interpreter paths in /nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20
/nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
/nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20...
/nix/store/czzc1r4ww7ryh48kifql38v549f5zfbs-easysnap-unstable-2018-11-20

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: easysnap

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20/bin
patching script interpreter paths in /nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20
/nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
/nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20...
/nix/store/hnc9k9pd8rg28mfn4j4569hba69fbd88-easysnap-unstable-2018-11-20

@timokau timokau merged commit 56821ae into NixOS:master Nov 21, 2018
@sjau sjau deleted the easysnap-2018-11-20 branch November 22, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjau @timokau @GrahamcOfBorg