Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd: Provide apparmor_parser #50831

Merged
merged 1 commit into from Nov 24, 2018
Merged

lxd: Provide apparmor_parser #50831

merged 1 commit into from Nov 24, 2018

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 20, 2018

Motivation for this change

Previously, lxd would complain about apparmor_parser being missing:

lxd[1037]: lvl=warn msg="AppArmor support has been disabled because 'apparmor_parser' couldn't be found" t=2018-11-19T18:32:47-0800

We need to provide a wrapped apparmor_parser that knows where to find <tunables/global>, which is #included by lxd’s generated profiles.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andersk
lxd: Provide apparmor_parser
291499d 
Previously, lxd would complain about apparmor_parser being missing:

lxd[1037]: lvl=warn msg="AppArmor support has been disabled because 'apparmor_parser' couldn't be found" t=2018-11-19T18:32:47-0800

We need to provide a wrapped apparmor_parser that knows where to find
<tunables/global>, which is #included by lxd’s generated profiles.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@joachifm
Copy link
Contributor

@GrahamcOfBorg build lxd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lxd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lxd

Partial log (click to expand)

shrinking /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin/bin/fuidshift
shrinking /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin/bin/lxd-p2c
shrinking /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin/bin/lxd-benchmark
shrinking /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin/bin/.lxd-wrapped
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin/bin
patching script interpreter paths in /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin
checking for references to /build in /nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/bj520jracim907zbla6zmqilrqkjr78w-lxd-3.0.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lxd

Partial log (click to expand)

shrinking /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin/bin/fuidshift
shrinking /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin/bin/lxd-p2c
shrinking /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin/bin/lxd-benchmark
shrinking /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin/bin/.lxd-wrapped
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin/bin
patching script interpreter paths in /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin
checking for references to /build in /nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/nbfxnjnwxp0wrka513dsja2fiif0k0h2-lxd-3.0.2-bin

@joachifm joachifm merged commit f00bc13 into NixOS:master Nov 24, 2018
@andersk andersk deleted the lxd-apparmor_parser branch December 10, 2019 09:00
@andersk andersk mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @joachifm @GrahamcOfBorg