[wip] Remove lib functions from all-packages.nix attrs #50776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids exposing them in nix-env -qa
matthewbauer
requested review from
edolstra,
FRidh,
LnL7,
Mic92 and
nbp
as code owners
dezgeg
reviewed
Nov 20, 2018
| ### Helper functions. | ||
| inherit lib config; | ||
|
|
||
| inherit (lib) lowPrio hiPrio appendToName makeOverridable; |
There was a problem hiding this comment.
You cannot remove these from here as it could break out-of-tree code.
There was a problem hiding this comment.
Mhm. The problem is that every change in nixpkgs can break out-of-tree code.
The question is, how much breakage would be acceptable.
matthewbauer
changed the title
|
yeah - this is definitely still a work in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There are a bunch of these lib functions exposed in all-packages.nix. We should be able to hide them behind a let binding.