Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyCA: init at 2.1 #50834

Merged
merged 2 commits into from Nov 24, 2018
Merged

pyCA: init at 2.1 #50834

merged 2 commits into from Nov 24, 2018

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

I wanted pyCA in nix! This needed the Python package sdnotify, too. Hope it's okay to add it inside this PR as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner November 20, 2018 09:44
peterhoeg
peterhoeg requested changes Nov 20, 2018
View reviewed changes
pkgs/applications/video/pyca/default.nix Show resolved Hide resolved
pkgs/applications/video/pyca/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@peterhoeg
Copy link
Member

CC @dotlambda @FRidh

@pmiddend
Copy link
Contributor Author

@peterhoeg I split the PR into two commits, one being the addition of sdconfig. Thanks for the input.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_help (tests.test_main.TestPycaMain) ... ok
test_run (tests.test_main.TestPycaMain) ... ok
test_sigterm (tests.test_main.TestPycaMain) ... ok
test_check (tests.test_config.TestPycaConfig) ... ok

----------------------------------------------------------------------
Ran 33 tests in 4.608s

OK
/nix/store/b348djhpc8v0brjc99x3064zgnkwiv1x-pyCA-2.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/handlers.py", line 144, in run
    self.close()
  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/simple_server.py", line 35, in close
    self.status.split(' ',1)[0], self.bytes_sent
AttributeError: 'NoneType' object has no attribute 'split'
----------------------------------------
part1part2
builder for '/nix/store/a7gz258819wqi46n6r7kzs09dlgsy6im-python3.7-pycurl-7.43.0.2.drv' failed with exit code 1
cannot build derivation '/nix/store/cn0qki9qd8f8lffpan3h90n8krxsfk32-pyCA-2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/cn0qki9qd8f8lffpan3h90n8krxsfk32-pyCA-2.1.drv' failed

@peterhoeg
Copy link
Member

I split the PR into two commits

Thanks.

@FRidh, anything else?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_start_capture_recording_command_failure (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigkill (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigterm (tests.test_capture.TestPycaCapture) ... ok
test_run (tests.test_agentstate.TestPycaAgentState) ... ok

----------------------------------------------------------------------
Ran 33 tests in 4.641s

OK
/nix/store/mcbcf2b715ka2581cnnd7ibd16w523j5-pyCA-2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_start_capture (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_recording_command_failure (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigkill (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigterm (tests.test_capture.TestPycaCapture) ... ok

----------------------------------------------------------------------
Ran 33 tests in 5.132s

OK
/nix/store/b348djhpc8v0brjc99x3064zgnkwiv1x-pyCA-2.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/handlers.py", line 144, in run
    self.close()
  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/simple_server.py", line 35, in close
    self.status.split(' ',1)[0], self.bytes_sent
AttributeError: 'NoneType' object has no attribute 'split'
----------------------------------------
part1part2
builder for '/nix/store/02j0afj41l7nn4d3fgilqklskwwz7lgj-python3.7-pycurl-7.43.0.2.drv' failed with exit code 1
cannot build derivation '/nix/store/gxvcvmlky56wcjav5lfjmn82a2s0szid-pyCA-2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gxvcvmlky56wcjav5lfjmn82a2s0szid-pyCA-2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_servicestate (tests.test_db.TestPycaDb) ... ok
test_status (tests.test_db.TestPycaDb) ... ok
test_get_schedule (tests.test_schedule.TestPycaCapture) ... ok
test_run (tests.test_schedule.TestPycaCapture) ... ok

----------------------------------------------------------------------
Ran 33 tests in 5.553s

OK
/nix/store/b348djhpc8v0brjc99x3064zgnkwiv1x-pyCA-2.1

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pyCA pythonPackages.sdnotify python36Packages.sdnotify

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyCA, pythonPackages.sdnotify, python36Packages.sdnotify

Partial log (click to expand)

    handler.run(self.server.get_app())
  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/handlers.py", line 144, in run
    self.close()
  File "/nix/store/p3ny0nvps8pn3wj7g38kk2bk3876bnf7-python3-3.7.1/lib/python3.7/wsgiref/simple_server.py", line 35, in close
    self.status.split(' ',1)[0], self.bytes_sent
AttributeError: 'NoneType' object has no attribute 'split'
part1part2
builder for '/nix/store/02j0afj41l7nn4d3fgilqklskwwz7lgj-python3.7-pycurl-7.43.0.2.drv' failed with exit code 1
cannot build derivation '/nix/store/pg9iazskc8gas07pa6wd5vx9p5p2b2ar-pyca-2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pg9iazskc8gas07pa6wd5vx9p5p2b2ar-pyca-2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_servicestate (tests.test_db.TestPycaDb) ... ok
test_status (tests.test_db.TestPycaDb) ... ok
test_get_schedule (tests.test_schedule.TestPycaCapture) ... ok
test_run (tests.test_schedule.TestPycaCapture) ... ok

----------------------------------------------------------------------
Ran 33 tests in 5.163s

OK
/nix/store/6223irp3yi7nz7dbrvfm9kqwzkr61r50-pyca-2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyCA, pythonPackages.sdnotify, python36Packages.sdnotify

Partial log (click to expand)

test_start_capture_sigkill (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigterm (tests.test_capture.TestPycaCapture) ... ok

----------------------------------------------------------------------
Ran 33 tests in 4.931s

OK
/nix/store/6223irp3yi7nz7dbrvfm9kqwzkr61r50-pyca-2.1
/nix/store/dx3lgdgvw17piji384kdwjmprk9q62sa-python2.7-sdnotify-0.3.2
/nix/store/8jca0k10qrkb5lrmjmn2zphyzpjhcvc0-python3.6-sdnotify-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pyCA

Partial log (click to expand)

test_start_capture_recording_command_failure (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigkill (tests.test_capture.TestPycaCapture) ... ok
test_start_capture_sigterm (tests.test_capture.TestPycaCapture) ... ok
test_run (tests.test_agentstate.TestPycaAgentState) ... ok

----------------------------------------------------------------------
Ran 33 tests in 4.951s

OK
/nix/store/cyvkrxicw8mi52j0glrqy60zl8vxh8nn-pyca-2.1

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 24, 2018 •
edited

Couldn't build pyCA locally because python3.7-pycurl-7.43.0.2 fails to build. See https://hydra.nixos.org/build/83635732

Using python36Packages.callPackage for pyCA will probably bypass that until that's fixed.

Edit: now it builds locally for me, strange.

@worldofpeace
Copy link
Contributor

The bot was able to build this fine several times so I think it's fine, however strange.

@worldofpeace worldofpeace merged commit 6dbf15d into NixOS:master Nov 24, 2018
@pmiddend pmiddend deleted the pyca-init-2.1 branch November 24, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@peterhoeg peterhoeg peterhoeg approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmiddend @peterhoeg @GrahamcOfBorg @worldofpeace