fix: use buildPackages.xsltProc in case of cross compilation #50804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very interesting. |
Mic92
reviewed
Nov 20, 2018
| @@ -57,7 +58,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| postInstall = '' | |||
| cd "$out/etc/fonts" | |||
| "${libxslt.bin}/bin/xsltproc" --stringparam fontDirectories "${dejavu_fonts.minimal}" \ | |||
| "${if (stdenv.hostPlatform != stdenv.buildPlatform) then buildPackages.libxslt.bin else libxslt.bin}/bin/xsltproc" --stringparam fontDirectories "${dejavu_fonts.minimal}" \ | |||
There was a problem hiding this comment.
Should buildPackages.libxslt.bin not always return the correct binary?
cc @matthewbauer
There was a problem hiding this comment.
buildPackages work fine when not cross compiling. pkgs = buildPackages = buildPackages.buildPackages in this case.
I would recommend putting libxslt.bin in nativeBuildInputs to avoid this logic though.
|
@eburimu why was this closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix cross compilation of fontconfig.
See: #50801
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)