Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 00adcec29a92
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ff26cc0276ef
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 20, 2018

  1. doc/reviewing-contributions: fix build error 

    Regression from #50674. Section IDs cannot contain spaces.
    @delroth
    delroth committed Nov 20, 2018
    1

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6b1d3dc View commit details

  2. Merge pull request #50820 from delroth/doc-build-fix 

    doc/reviewing-contributions: fix build error
    @srhb
    srhb authored Nov 20, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ff26cc0 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 doc/reviewing-contributions.xml
2 changes: 1 addition & 1 deletion doc/reviewing-contributions.xml
View file
Original file line number Diff line number Diff line change
@@ -583,7 +583,7 @@ $ nix-shell -p nox --run "nox-review -k pr PRNUMBER"
pull requests fitting this category.
</para>
</section>
<section xml:id="reviewing-contributions--merging-pull requests">
<section xml:id="reviewing-contributions--merging-pull-requests">
<title>Merging pull requests</title>

<para>