Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade and fix few broken python packages #51230

Merged
merged 12 commits into from Nov 30, 2018
Merged

Upgrade and fix few broken python packages #51230

merged 12 commits into from Nov 30, 2018

Conversation

costrouc
Copy link
Member

Motivation for this change

Upgrade and fix few broken python packages. Enabled tests if disabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner November 29, 2018 14:01
@costrouc costrouc force-pushed the costrouc/python-package-upgrades branch from 8f7149b to f4bd488 Compare November 29, 2018 14:20
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.livereload python2Packages.livereload python2Packages.ruamel_yaml python3Packages.ruamel_yaml python2Packages.chalice python3Packages.chalice python3Packages.PyLTI python2Packages.PyLTI python2Packages.jmespath python3Packages.jmespath python2Packages.nose-randomly python3Packages.nose-randomly python2Packages.httpretty python3Packages.httpretty python2Pacakges.factory_boy python3Packages.factory_boy python2Pacakges.Quandl python3Packages.Quandl

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python3Packages.livereload, python2Packages.livereload, python2Packages.ruamel_yaml, python3Packages.ruamel_yaml, python2Packages.chalice, python3Packages.chalice, python2Packages.PyLTI, python2Packages.jmespath, python3Packages.jmespath, python2Packages.nose-randomly, python3Packages.nose-randomly, python2Packages.httpretty, python3Packages.httpretty, python3Packages.factory_boy, python3Packages.Quandl

The following builds were skipped because they don't evaluate on x86_64-linux: python3Packages.PyLTI, python2Pacakges.factory_boy, python2Pacakges.Quandl

Partial log (click to expand)

patching script interpreter paths in /nix/store/qh30jsqzvswr5li80v8lvw7fz437glb4-python3.7-factory_boy-2.11.1
checking for references to /build in /nix/store/qh30jsqzvswr5li80v8lvw7fz437glb4-python3.7-factory_boy-2.11.1...
running install tests

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
cannot build derivation '/nix/store/x7hc0i5k27y0mqi8z70hzzjnssdv7zpv-python3.7-Quandl-3.4.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/6vr5zw5yszprd56dw2z4r712dn5dv2qi-python3.7-chalice-1.6.1.drv', '/nix/store/gpsljmpi6j8wfqjw1kvpwccllvrr6hhy-python3.7-httpretty-0.9.6.drv', '/nix/store/x7hc0i5k27y0mqi8z70hzzjnssdv7zpv-python3.7-Quandl-3.4.5.drv' failed

dotlambda
dotlambda reviewed Nov 29, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pythonPackages.ruamel_yaml: 0.15.80 -> 0.15.80

This doesn't seem correct ;-)

@dotlambda
Copy link
Member

You might want to target the python-unstable branch instead. For example, ruamel_yaml has also been updated there.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python3Packages.livereload, python2Packages.livereload, python2Packages.ruamel_yaml, python3Packages.ruamel_yaml, python2Packages.chalice, python3Packages.chalice, python2Packages.PyLTI, python2Packages.jmespath, python3Packages.jmespath, python2Packages.nose-randomly, python3Packages.nose-randomly, python2Packages.httpretty, python3Packages.httpretty, python3Packages.factory_boy, python3Packages.Quandl

The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.PyLTI, python2Pacakges.factory_boy, python2Pacakges.Quandl

Partial log (click to expand)


=============================== warnings summary ===============================
pylti/tests/test_flask.py::TestFlask::test_access_to_oauth_resource
  /nix/store/sdw4p9lls1zx1dhv4lzr2kdcmb0k0afv-python2.7-Flask-1.0.2/lib/python2.7/site-packages/flask/sessions.py:208: UserWarning: "localhost" is not a valid cookie domain, it must contain a ".". Add an entry to your hosts file, for example "localhost.localdomain", and use that instead.
    ' "{rv}.localdomain", and use that instead.'.format(rv=rv)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 85 passed, 1 warnings in 2.00 seconds =====================
pytestcachePhase
error: build of '/nix/store/9sv1f5v48h43hh35ak2gqmjqb5ia5bq0-python3.7-chalice-1.6.1.drv' failed

@costrouc
Copy link
Member Author

@dotlambda didn't know about python-unstable until recently. I will rebase on python-unstable.

@costrouc costrouc force-pushed the costrouc/python-package-upgrades branch from f4bd488 to fac9b74 Compare November 29, 2018 15:00
@costrouc costrouc changed the base branch from master to python-unstable November 29, 2018 15:00
@costrouc costrouc force-pushed the costrouc/python-package-upgrades branch from fac9b74 to d481507 Compare November 29, 2018 15:27
@costrouc costrouc force-pushed the costrouc/python-package-upgrades branch from d481507 to 62227c1 Compare November 29, 2018 16:07
c0bw3b
c0bw3b reviewed Nov 29, 2018
View reviewed changes
pkgs/development/python-modules/nose-randomly/default.nix
meta = with lib; {
description = "Nose plugin to randomly order tests and control random.seed";
homepage = https://github.com/adamchainz/nose-randomly;
license = licenses.bsdOriginal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.bsdOriginal;
license = licenses.bsd3;

according to https://github.com/adamchainz/nose-randomly/blob/master/LICENSE
(bsdOriginal is actually the old BSD-4-Clause)

@worldofpeace
Copy link
Contributor

How about changing the PyLTI commit msg to pythonPackages.PyLTI: add chalice as dependency fixing build?

@costrouc costrouc force-pushed the costrouc/python-package-upgrades branch from 62227c1 to d8762ce Compare November 29, 2018 19:19
@dotlambda dotlambda merged commit 93e6f5a into NixOS:python-unstable Nov 30, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

nose-randomly license is still wrong in the merged commits

@dotlambda
Copy link
Member

Fixed in python-unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dotlambda dotlambda dotlambda left review comments

@c0bw3b c0bw3b c0bw3b left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@costrouc @GrahamcOfBorg @dotlambda @worldofpeace @c0bw3b @Mic92