Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-secrets: install manpage #51228

Merged
merged 1 commit into from Dec 1, 2018
Merged

git-secrets: install manpage #51228

merged 1 commit into from Dec 1, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [X NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

@GrahamcOfBorg build git-secrets

@marsam marsam force-pushed the feature/git-secrets-manpage branch from 0b73294 to dd319d3 Compare December 1, 2018 01:35
worldofpeace
worldofpeace reviewed Dec 1, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that your wrapping it with gawk gnused now.
Was that to fix something else?
If so can you update the commit msg or use another commit?

Other than that, I can view the manual when installed with nix-env 👍

@marsam
Copy link
Contributor Author

marsam commented Dec 1, 2018 •
edited

Was that to fix something else?

not quite, since git-secrets uses sed and awk I thought it would be better to wrap them

@marsam marsam force-pushed the feature/git-secrets-manpage branch from dd319d3 to 7476972 Compare December 1, 2018 15:34
@worldofpeace worldofpeace merged commit eb75550 into NixOS:master Dec 1, 2018
@worldofpeace
Copy link
Contributor

@marsam Thanks again ✨

@marsam marsam deleted the feature/git-secrets-manpage branch December 1, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @c0bw3b @worldofpeace @GrahamcOfBorg